Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspaceify auto #3829

Merged
merged 10 commits into from
Jan 6, 2023
Merged

Workspaceify auto #3829

merged 10 commits into from
Jan 6, 2023

Conversation

welbon
Copy link
Contributor

@welbon welbon commented Jan 4, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #3829 (f9f34d9) into master (ce4b2c9) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3829      +/-   ##
==========================================
- Coverage   53.19%   53.13%   -0.05%     
==========================================
  Files         595      595              
  Lines       64700    64702       +2     
==========================================
- Hits        34410    34374      -36     
- Misses      30290    30328      +38     
Flag Coverage Δ
unittests 53.13% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
block-relayer/src/block_relayer.rs 25.64% <ø> (ø)
chain/mock/src/mock_chain.rs 78.79% <ø> (ø)
chain/open-block/src/lib.rs 79.80% <ø> (ø)
chain/src/chain.rs 65.08% <ø> (ø)
chain/src/verifier/mod.rs 76.82% <ø> (ø)
cmd/miner_client/src/cpu_solver.rs 69.08% <ø> (ø)
cmd/miner_client/src/job_client.rs 0.00% <ø> (ø)
cmd/miner_client/src/miner.rs 89.40% <ø> (ø)
cmd/miner_client/src/stratum_client.rs 0.00% <ø> (ø)
cmd/miner_client/src/stratum_client_service.rs 0.00% <ø> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4b2c9...f9f34d9. Read the comment docs.

@nkysg nkysg enabled auto-merge (squash) January 6, 2023 07:00
@nkysg nkysg self-requested a review January 6, 2023 07:00
@nkysg nkysg merged commit 34dadaa into master Jan 6, 2023
@nkysg nkysg deleted the workspaceify-auto branch January 6, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] refactor cargo.toml use workspace to remove redundant move-vm-runtime
2 participants