Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert code and use new method to fix publish_module_bundle crash #3822

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Dec 21, 2022

Pull request type

use simply method same with #3817
Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@nkysg nkysg requested a review from xudon9 December 21, 2022 02:11
@nkysg nkysg requested review from sanlee42, WGB5445 and welbon and removed request for xudon9 and templexxx December 21, 2022 02:11
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #3822 (4579ea1) into master (10f3e78) will increase coverage by 0.04%.
The diff coverage is 33.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3822      +/-   ##
==========================================
+ Coverage   53.14%   53.18%   +0.04%     
==========================================
  Files         595      595              
  Lines       64674    64668       -6     
==========================================
+ Hits        34366    34385      +19     
+ Misses      30308    30283      -25     
Flag Coverage Δ
unittests 53.18% <33.34%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ove-package-manager/src/compatibility_check_cmd.rs 0.00% <0.00%> (ø)
vm/compiler/src/lib.rs 77.64% <28.58%> (+0.78%) ⬆️
abi/resolver/src/lib.rs 71.16% <60.00%> (-0.23%) ⬇️
account/service/src/account_events.rs 74.51% <0.00%> (-7.84%) ⬇️
chain/chain-notify/src/lib.rs 92.76% <0.00%> (-5.79%) ⬇️
network-p2p/src/discovery.rs 72.21% <0.00%> (-1.01%) ⬇️
...ons/forkable-jellyfish-merkle/src/node_type/mod.rs 91.44% <0.00%> (-0.55%) ⬇️
sync/src/sync.rs 62.06% <0.00%> (+0.45%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10f3e78...4579ea1. Read the comment docs.

@nkysg nkysg enabled auto-merge (squash) December 21, 2022 03:18
@nkysg nkysg merged commit d57b055 into master Dec 21, 2022
@nkysg nkysg deleted the revert_publish_module_bundle branch December 21, 2022 03:19
@github-actions
Copy link

Benchmark for bcb9f76

Click to view benchmark
Test Base PR %
accumulator_append 611.5±26.75µs 605.9±29.03µs -0.92%
block_apply/block_apply_10 792.8±2.55ms 793.5±1.30ms +0.09%
block_apply/block_apply_1000 80.6±0.06s 80.8±0.10s +0.25%
get_with_proof/db_store 36.6±0.27µs 36.3±0.29µs -0.82%
get_with_proof/mem_store 31.5±0.21µs 31.4±0.23µs -0.32%
put_and_commit/db_store/1 95.9±4.80µs 95.7±4.96µs -0.21%
put_and_commit/db_store/10 855.9±39.50µs 852.0±39.80µs -0.46%
put_and_commit/db_store/100 7.3±0.32ms 7.3±0.31ms 0.00%
put_and_commit/db_store/5 438.3±21.21µs 436.7±21.80µs -0.37%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 61.6±5.61µs 61.7±5.61µs +0.16%
put_and_commit/mem_store/10 576.0±46.47µs 576.7±46.79µs +0.12%
put_and_commit/mem_store/100 5.6±0.34ms 5.7±0.82ms +1.79%
put_and_commit/mem_store/5 291.4±24.56µs 291.6±24.20µs +0.07%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 7.2±0.54ms 6.9±0.26ms -4.17%
query_block/query_block_in(10)_times(1000) 69.7±1.80ms 69.8±2.34ms +0.14%
query_block/query_block_in(10)_times(10000) 697.4±28.53ms 692.9±14.25ms -0.65%
query_block/query_block_in(1000)_times(100) 997.5±11.01µs 992.9±13.09µs -0.46%
query_block/query_block_in(1000)_times(1000) 9.9±0.16ms 10.0±0.16ms +1.01%
query_block/query_block_in(1000)_times(10000) 99.2±1.18ms 100.3±1.47ms +1.11%
storage_transaction 982.3±273.68µs 1133.1±373.93µs +15.35%
vm/transaction_execution/1 907.4±2.22ms 899.4±1.59ms -0.88%
vm/transaction_execution/10 229.9±1.96ms 227.4±0.46ms -1.09%
vm/transaction_execution/20 198.5±3.06ms 197.1±1.63ms -0.71%
vm/transaction_execution/5 302.0±0.61ms 299.8±1.29ms -0.73%
vm/transaction_execution/50 213.5±0.63ms 212.8±3.40ms -0.33%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants