Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: dev get-coin don't check account #3589

Merged
merged 1 commit into from
Jul 31, 2022
Merged

cli: dev get-coin don't check account #3589

merged 1 commit into from
Jul 31, 2022

Conversation

YouNeedWork
Copy link
Contributor

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #3588

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #3589 (edf864f) into master (3a0c707) will increase coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3589      +/-   ##
==========================================
+ Coverage   29.05%   29.20%   +0.16%     
==========================================
  Files         589      589              
  Lines       49814    49817       +3     
  Branches    23441    23433       -8     
==========================================
+ Hits        14468    14545      +77     
+ Misses      21138    21099      -39     
+ Partials    14208    14173      -35     
Flag Coverage Δ
unittests 29.20% <0.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/starcoin/src/dev/get_coin_cmd.rs 0.00% <0.00%> (ø)
vm/types/src/transaction_metadata.rs 55.23% <0.00%> (-8.95%) ⬇️
state/state-tree/src/mock/mod.rs 39.14% <0.00%> (-4.34%) ⬇️
...mons/forkable-jellyfish-merkle/src/iterator/mod.rs 41.50% <0.00%> (-4.00%) ⬇️
config/src/account_provider_config.rs 25.40% <0.00%> (-3.17%) ⬇️
vm/compiler/src/lib.rs 32.29% <0.00%> (-2.36%) ⬇️
config/src/helper.rs 43.14% <0.00%> (-1.96%) ⬇️
commons/utils/src/mpsc.rs 51.79% <0.00%> (-1.78%) ⬇️
commons/stream-task/src/task_stream.rs 60.00% <0.00%> (-1.42%) ⬇️
vm/types/src/token/token_value.rs 55.56% <0.00%> (-1.38%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0c707...edf864f. Read the comment docs.

@jolestar jolestar linked an issue Jul 31, 2022 that may be closed by this pull request
@jolestar jolestar merged commit 2529049 into starcoinorg:master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dev] make starcoin console be able to send faucet to any addr
2 participants