check export snapshot status with the manifest file #3561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 7db8e4eClick to view benchmark
|
nkysg
reviewed
Jul 25, 2022
| os.system(export_snapshot_cmd) | ||
| export_status = os.system( | ||
| "bash -c \"if [ $(less /sc-data/snapshot/manifest.csv| grep state_node | awk -F ' ' '{print$2}') -eq $(less /sc-data/snapshot/state_node | wc -l) ]; then exit 0; else exit 1;fi\"") |
There was a problem hiding this comment.
这里五个文件都的检测下
好的。
…napshot export failed
nkysg
approved these changes
Jul 25, 2022
Codecov Report
@@ Coverage Diff @@
## master #3561 +/- ##
==========================================
+ Coverage 29.12% 29.35% +0.24%
==========================================
Files 589 589
Lines 49753 49805 +52
Branches 23411 23433 +22
==========================================
+ Hits 14486 14617 +131
- Misses 20842 20850 +8
+ Partials 14425 14338 -87
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Benchmark for 87c572cClick to view benchmark
|
jolestar
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently the export snapshot process may be failed for some unknown reason, so we should add some check logic to make the snapshot is correct for sure.
Other information
#3539