Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add import snapshot file lines num check #3545

Merged
merged 2 commits into from
Jul 19, 2022
Merged

add import snapshot file lines num check #3545

merged 2 commits into from
Jul 19, 2022

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Jul 18, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #3539

What is the new behavior?

Other information

need modify scripts/sync_block.py。It's describe in #3539 @yourmoonlight

@nkysg nkysg requested review from templexxx and jolestar as code owners July 18, 2022 13:28
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #3545 (1aed8ad) into master (29cf2b5) will decrease coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3545      +/-   ##
==========================================
- Coverage   29.61%   29.25%   -0.36%     
==========================================
  Files         589      589              
  Lines       49753    49753              
  Branches    23420    23419       -1     
==========================================
- Hits        14731    14550     -181     
+ Misses      20810    20803       -7     
- Partials    14212    14400     +188     
Flag Coverage Δ
unittests 29.25% <ø> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test-helper/src/dummy_network_service.rs 22.23% <0.00%> (-14.81%) ⬇️
vm/types/src/on_chain_config/mod.rs 38.36% <0.00%> (-13.69%) ⬇️
executor/src/block_executor.rs 25.59% <0.00%> (-9.30%) ⬇️
vm/types/src/transaction_metadata.rs 55.23% <0.00%> (-8.95%) ⬇️
consensus/src/dummy.rs 65.22% <0.00%> (-8.69%) ⬇️
chain/open-block/src/lib.rs 32.46% <0.00%> (-8.60%) ⬇️
commons/accumulator/src/tree.rs 50.74% <0.00%> (-6.89%) ⬇️
chain/src/verifier/mod.rs 34.51% <0.00%> (-5.63%) ⬇️
commons/forkable-jellyfish-merkle/src/lib.rs 40.23% <0.00%> (-4.98%) ⬇️
vm/natives/src/token.rs 26.67% <0.00%> (-4.44%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29cf2b5...1aed8ad. Read the comment docs.

@github-actions
Copy link

Benchmark for f698f03

Click to view benchmark
Test Base PR %
accumulator_append 594.9±11.24µs 592.1±10.65µs -0.47%
block_apply/block_apply_10 265.7±0.50ms 263.6±0.50ms -0.79%
block_apply/block_apply_1000 27.1±0.03s 26.9±0.02s -0.74%
get_with_proof/db_store 36.5±0.36µs 36.4±0.29µs -0.27%
get_with_proof/mem_store 31.3±0.13µs 31.4±0.17µs +0.32%
put_and_commit/db_store/1 94.7±4.70µs 95.0±6.05µs +0.32%
put_and_commit/db_store/10 860.4±40.47µs 859.1±39.13µs -0.15%
put_and_commit/db_store/100 7.3±0.31ms 7.4±0.29ms +1.37%
put_and_commit/db_store/5 439.3±22.01µs 435.4±20.94µs -0.89%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 61.7±5.57µs 61.6±5.63µs -0.16%
put_and_commit/mem_store/10 580.8±48.13µs 578.6±49.22µs -0.38%
put_and_commit/mem_store/100 5.7±0.83ms 5.7±0.83ms 0.00%
put_and_commit/mem_store/5 294.0±25.53µs 292.0±25.83µs -0.68%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.07ms 3.9±0.12ms 0.00%
query_block/query_block_in(10)_times(1000) 39.1±1.45ms 38.9±0.91ms -0.51%
query_block/query_block_in(10)_times(10000) 390.9±8.12ms 390.8±4.35ms -0.03%
query_block/query_block_in(1000)_times(100) 958.1±4.36µs 968.6±5.41µs +1.10%
query_block/query_block_in(1000)_times(1000) 9.6±0.08ms 9.6±0.06ms 0.00%
query_block/query_block_in(1000)_times(10000) 95.9±1.14ms 96.5±0.70ms +0.63%
storage_transaction 1058.5±313.08µs 1063.9±300.16µs +0.51%
vm/transaction_execution/1 313.7±1.38ms 311.8±0.83ms -0.61%
vm/transaction_execution/10 98.9±0.73ms 98.4±0.24ms -0.51%
vm/transaction_execution/20 92.1±0.29ms 91.5±0.11ms -0.65%
vm/transaction_execution/5 120.5±0.84ms 120.2±0.95ms -0.25%
vm/transaction_execution/50 106.5±0.44ms 106.0±0.18ms -0.47%

@nkysg
Copy link
Collaborator Author

nkysg commented Jul 18, 2022

@yourmoonlight please help me modify sync_block.py, it describe in #3539

@github-actions
Copy link

Benchmark for 9562289

Click to view benchmark
Test Base PR %
accumulator_append 590.6±9.98µs 592.1±11.00µs +0.25%
block_apply/block_apply_10 264.5±0.63ms 267.5±1.75ms +1.13%
block_apply/block_apply_1000 27.0±0.04s 27.0±0.02s 0.00%
get_with_proof/db_store 36.2±0.28µs 36.3±0.50µs +0.28%
get_with_proof/mem_store 31.2±0.22µs 31.5±0.24µs +0.96%
put_and_commit/db_store/1 95.1±4.84µs 94.1±4.86µs -1.05%
put_and_commit/db_store/10 851.8±37.41µs 856.4±40.50µs +0.54%
put_and_commit/db_store/100 7.4±0.34ms 7.3±0.28ms -1.35%
put_and_commit/db_store/5 436.9±21.84µs 437.0±22.57µs +0.02%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.16ms 0.00%
put_and_commit/mem_store/1 61.8±5.63µs 61.4±5.68µs -0.65%
put_and_commit/mem_store/10 576.9±47.69µs 574.7±48.81µs -0.38%
put_and_commit/mem_store/100 5.6±0.34ms 5.6±0.82ms 0.00%
put_and_commit/mem_store/5 290.8±24.57µs 290.7±25.49µs -0.03%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.07ms 3.9±0.07ms 0.00%
query_block/query_block_in(10)_times(1000) 39.0±0.72ms 38.4±1.37ms -1.54%
query_block/query_block_in(10)_times(10000) 391.8±8.29ms 386.3±8.58ms -1.40%
query_block/query_block_in(1000)_times(100) 963.9±7.11µs 967.1±8.75µs +0.33%
query_block/query_block_in(1000)_times(1000) 9.6±0.07ms 9.6±0.14ms 0.00%
query_block/query_block_in(1000)_times(10000) 96.6±0.80ms 96.6±1.02ms 0.00%
storage_transaction 1052.2±296.51µs 1076.4±355.48µs +2.30%
vm/transaction_execution/1 311.1±1.63ms 311.3±1.59ms +0.06%
vm/transaction_execution/10 98.3±0.84ms 99.0±1.95ms +0.71%
vm/transaction_execution/20 91.7±1.14ms 91.7±0.47ms 0.00%
vm/transaction_execution/5 119.5±0.42ms 119.6±0.27ms +0.08%
vm/transaction_execution/50 105.8±0.63ms 106.6±1.27ms +0.76%

@jolestar jolestar merged commit f0cb3b2 into master Jul 19, 2022
@jolestar jolestar deleted the check_accumulator branch July 19, 2022 04:21
@yourmoonlight
Copy link
Collaborator

@yourmoonlight please help me modify sync_block.py, it describe in #3539

Ok, I will take a look.

jiangying000 pushed a commit to jiangying000/starcoin that referenced this pull request Jul 22, 2022
* add import snapshot file lines num check

* use Iterator count method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants