Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some dependabot alter #3485

Merged
merged 2 commits into from
Jun 27, 2022
Merged

fix some dependabot alter #3485

merged 2 commits into from
Jun 27, 2022

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Jun 27, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):
    hyper, tiny_http, rust_embed fix potential security upgrade

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@nkysg nkysg requested review from templexxx and jolestar as code owners June 27, 2022 07:21
@nkysg nkysg enabled auto-merge (squash) June 27, 2022 07:44
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #3485 (2bd161b) into master (52289a6) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3485      +/-   ##
==========================================
- Coverage   31.30%   31.27%   -0.02%     
==========================================
  Files         500      500              
  Lines       46900    46900              
  Branches    22129    22122       -7     
==========================================
- Hits        14678    14665      -13     
+ Misses      18014    17988      -26     
- Partials    14208    14247      +39     
Flag Coverage Δ
unittests 31.27% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/faucet/src/web.rs 0.00% <ø> (ø)
consensus/src/dummy.rs 65.22% <0.00%> (-13.04%) ⬇️
chain/src/verifier/mod.rs 35.16% <0.00%> (-8.59%) ⬇️
vm/types/src/transaction_metadata.rs 55.23% <0.00%> (-7.46%) ⬇️
consensus/src/consensus.rs 55.56% <0.00%> (-4.76%) ⬇️
chain/open-block/src/lib.rs 33.12% <0.00%> (-3.97%) ⬇️
config/src/helper.rs 43.14% <0.00%> (-3.92%) ⬇️
sync/src/block_connector/test_write_block_chain.rs 32.56% <0.00%> (-3.87%) ⬇️
network-p2p/src/transport.rs 15.10% <0.00%> (-3.77%) ⬇️
commons/utils/src/mpsc.rs 51.79% <0.00%> (-3.57%) ⬇️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc4f616...2bd161b. Read the comment docs.

@nkysg nkysg merged commit 8c6c752 into master Jun 27, 2022
@nkysg nkysg deleted the dependabot_alerts branch June 27, 2022 08:20
@github-actions
Copy link

Benchmark for ae0418c

Click to view benchmark
Test Base PR %
accumulator_append 596.2±12.66µs 599.0±9.44µs +0.47%
block_apply/block_apply_10 264.6±1.18ms 265.0±1.15ms +0.15%
block_apply/block_apply_1000 27.0±0.03s 27.3±0.03s +1.11%
get_with_proof/db_store 36.1±0.34µs 36.3±0.59µs +0.55%
get_with_proof/mem_store 31.5±0.23µs 31.6±0.20µs +0.32%
put_and_commit/db_store/1 95.9±4.70µs 96.0±4.97µs +0.10%
put_and_commit/db_store/10 859.3±40.80µs 854.1±39.98µs -0.61%
put_and_commit/db_store/100 7.3±0.33ms 7.4±0.32ms +1.37%
put_and_commit/db_store/5 436.7±22.00µs 445.0±23.76µs +1.90%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 62.0±5.59µs 62.0±5.59µs 0.00%
put_and_commit/mem_store/10 578.7±46.72µs 587.8±57.83µs +1.57%
put_and_commit/mem_store/100 5.7±0.82ms 5.7±0.82ms 0.00%
put_and_commit/mem_store/5 291.6±24.49µs 294.0±25.54µs +0.82%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.12ms 3.9±0.11ms 0.00%
query_block/query_block_in(10)_times(1000) 38.7±1.08ms 39.2±0.78ms +1.29%
query_block/query_block_in(10)_times(10000) 388.8±7.26ms 389.7±7.71ms +0.23%
query_block/query_block_in(1000)_times(100) 955.9±5.66µs 962.2±6.37µs +0.66%
query_block/query_block_in(1000)_times(1000) 9.6±0.05ms 9.7±0.11ms +1.04%
query_block/query_block_in(1000)_times(10000) 95.8±0.65ms 97.4±0.44ms +1.67%
storage_transaction 1048.3±274.93µs 1048.1±272.81µs -0.02%
vm/transaction_execution/1 311.9±4.05ms 313.2±4.99ms +0.42%
vm/transaction_execution/10 98.6±1.32ms 98.3±0.28ms -0.30%
vm/transaction_execution/20 91.3±0.38ms 91.9±0.45ms +0.66%
vm/transaction_execution/5 119.7±0.41ms 120.0±0.66ms +0.25%
vm/transaction_execution/50 105.6±0.39ms 106.0±0.51ms +0.38%

nkysg added a commit that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants