-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wrong behavior: submit multisig txn only there are enough signatures #3482
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3482 +/- ##
==========================================
- Coverage 31.29% 31.06% -0.23%
==========================================
Files 500 500
Lines 46900 46900
Branches 22129 22129
==========================================
- Hits 14675 14564 -111
+ Misses 18109 18022 -87
- Partials 14116 14314 +198
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
… execution 1. eprint multisig signatures filepath in txn execution 2. get txn output when there are enough multisig signatures
…esting 1. submit directly 2. sign to file first, then submit
Need to fix the submit-txn, I wonder how to get value directlly in test like this?
|
use or you can return a struct like:
use |
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Ignore signatrues' count but submit directly because my mistake.
Issue Number: N/A
What is the new behavior?
Other information