Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd] Upgrade airdrop command to use new TransferScripts::batch_peer_to_peer_v2 #3264

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Mar 4, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Upgrade airdrop command to use new TransferScripts::batch_peer_to_peer_v2

Issue Number: N/A

What is the new behavior?

Other information

@jolestar jolestar requested review from nanne007 and sanlee42 March 4, 2022 07:40
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #3264 (966981c) into master (ee94909) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3264      +/-   ##
==========================================
- Coverage   31.97%   31.77%   -0.19%     
==========================================
  Files         493      500       +7     
  Lines       46062    46254     +192     
  Branches    21144    21217      +73     
==========================================
- Hits        14722    14691      -31     
+ Misses      17417    17407      -10     
- Partials    13923    14156     +233     
Flag Coverage Δ
unittests 31.77% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/account_config/resources/auto_accept_token.rs 0.00% <0.00%> (ø)
vm/natives/src/account.rs 12.50% <0.00%> (-18.75%) ⬇️
network-p2p/src/transport.rs 15.10% <0.00%> (-16.98%) ⬇️
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.66%) ⬇️
network/src/worker.rs 30.65% <0.00%> (-11.29%) ⬇️
vm/types/src/transaction/error.rs 3.58% <0.00%> (-10.71%) ⬇️
vm/natives/src/lib.rs 80.00% <0.00%> (-10.00%) ⬇️
commons/forkable-jellyfish-merkle/src/lib.rs 41.38% <0.00%> (-6.89%) ⬇️
vm/types/src/transaction_metadata.rs 56.72% <0.00%> (-5.97%) ⬇️
vm/types/src/on_chain_config/mod.rs 41.10% <0.00%> (-5.47%) ⬇️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee94909...966981c. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

Benchmark for 2e7fc41

Click to view benchmark
Test Base PR %
accumulator_append 589.7±11.35µs 587.1±9.06µs -0.44%
block_apply/block_apply_10 266.0±1.33ms 269.0±1.08ms +1.13%
block_apply/block_apply_1000 27.4±0.03s 27.2±0.01s -0.73%
get_with_proof/db_store 36.0±0.44µs 36.4±0.60µs +1.11%
get_with_proof/mem_store 31.1±0.31µs 30.9±0.26µs -0.64%
put_and_commit/db_store/1 95.1±4.46µs 94.7±4.78µs -0.42%
put_and_commit/db_store/10 848.4±35.71µs 854.5±41.27µs +0.72%
put_and_commit/db_store/100 7.3±0.33ms 7.3±0.34ms 0.00%
put_and_commit/db_store/5 434.9±21.86µs 434.0±20.64µs -0.21%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.16ms 0.00%
put_and_commit/mem_store/1 61.1±5.50µs 61.1±5.29µs 0.00%
put_and_commit/mem_store/10 572.2±48.08µs 571.6±45.30µs -0.10%
put_and_commit/mem_store/100 5.6±0.81ms 5.6±0.33ms 0.00%
put_and_commit/mem_store/5 289.7±27.57µs 288.0±23.96µs -0.59%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.09ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.13ms 3.8±0.11ms -2.56%
query_block/query_block_in(10)_times(1000) 38.9±1.35ms 39.4±1.10ms +1.29%
query_block/query_block_in(10)_times(10000) 383.9±8.31ms 385.9±4.45ms +0.52%
query_block/query_block_in(1000)_times(100) 951.9±9.45µs 948.2±9.08µs -0.39%
query_block/query_block_in(1000)_times(1000) 9.6±0.10ms 9.5±0.11ms -1.04%
query_block/query_block_in(1000)_times(10000) 95.6±1.42ms 94.4±0.92ms -1.26%
storage_transaction 1052.4±305.82µs 1029.0±274.19µs -2.22%
vm/transaction_execution/1 320.6±8.19ms 317.5±1.91ms -0.97%
vm/transaction_execution/10 99.2±0.61ms 99.2±0.58ms 0.00%
vm/transaction_execution/20 91.6±0.90ms 91.7±1.33ms +0.11%
vm/transaction_execution/5 122.0±1.82ms 121.9±0.99ms -0.08%
vm/transaction_execution/50 103.2±0.51ms 102.9±0.46ms -0.29%

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

Benchmark for d29e0b0

Click to view benchmark
Test Base PR %
accumulator_append 594.0±12.21µs 595.6±11.98µs +0.27%
block_apply/block_apply_10 267.0±1.37ms 268.5±2.13ms +0.56%
block_apply/block_apply_1000 27.3±0.03s 27.5±0.02s +0.73%
get_with_proof/db_store 36.7±0.73µs 36.5±0.52µs -0.54%
get_with_proof/mem_store 31.9±0.39µs 31.5±0.29µs -1.25%
put_and_commit/db_store/1 94.4±4.70µs 96.4±7.23µs +2.12%
put_and_commit/db_store/10 849.0±41.23µs 862.4±51.36µs +1.58%
put_and_commit/db_store/100 7.4±0.31ms 7.4±0.31ms 0.00%
put_and_commit/db_store/5 435.1±22.36µs 438.6±22.64µs +0.80%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.18ms 0.00%
put_and_commit/mem_store/1 61.3±5.59µs 61.8±5.45µs +0.82%
put_and_commit/mem_store/10 574.0±48.23µs 581.9±48.22µs +1.38%
put_and_commit/mem_store/100 5.7±0.79ms 5.7±0.80ms 0.00%
put_and_commit/mem_store/5 287.9±23.58µs 292.2±25.18µs +1.49%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.07ms 3.9±0.15ms 0.00%
query_block/query_block_in(10)_times(1000) 39.3±1.03ms 39.0±0.99ms -0.76%
query_block/query_block_in(10)_times(10000) 384.2±5.97ms 388.3±5.57ms +1.07%
query_block/query_block_in(1000)_times(100) 945.5±7.05µs 950.8±5.63µs +0.56%
query_block/query_block_in(1000)_times(1000) 9.5±0.08ms 9.5±0.08ms 0.00%
query_block/query_block_in(1000)_times(10000) 94.5±0.83ms 94.9±0.72ms +0.42%
storage_transaction 1094.9±353.32µs 1045.5±277.59µs -4.51%
vm/transaction_execution/1 317.0±1.40ms 317.2±2.26ms +0.06%
vm/transaction_execution/10 99.3±0.82ms 99.2±0.42ms -0.10%
vm/transaction_execution/20 91.5±0.60ms 91.4±0.39ms -0.11%
vm/transaction_execution/5 122.0±1.55ms 122.1±1.53ms +0.08%
vm/transaction_execution/50 103.4±1.16ms 103.3±0.84ms -0.10%

@sanlee42 sanlee42 merged commit 4cdccaa into master Mar 9, 2022
@sanlee42 sanlee42 deleted the airdrop branch March 9, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants