Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube: liveness and readiness probe #3085

Merged
merged 1 commit into from
Dec 13, 2021
Merged

kube: liveness and readiness probe #3085

merged 1 commit into from
Dec 13, 2021

Conversation

sanlee42
Copy link
Member

No description provided.

@sanlee42 sanlee42 requested review from ssyuan and jolestar December 13, 2021 04:59
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #3085 (6eb190c) into master (e87fc49) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3085      +/-   ##
==========================================
+ Coverage   33.19%   33.27%   +0.08%     
==========================================
  Files         518      518              
  Lines       46710    46710              
  Branches    21364    21379      +15     
==========================================
+ Hits        15502    15538      +36     
- Misses      16595    16691      +96     
+ Partials    14613    14481     -132     
Flag Coverage Δ
unittests 33.27% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/types/src/language_storage_ext.rs 50.00% <0.00%> (-50.00%) ⬇️
vm/types/src/on_chain_config/vm_config.rs 36.67% <0.00%> (-13.33%) ⬇️
abi/decoder/src/lib.rs 1.58% <0.00%> (-8.66%) ⬇️
...ccount_config/resources/module_upgrade_strategy.rs 34.29% <0.00%> (-8.57%) ⬇️
rpc/api/src/contract_api.rs 11.77% <0.00%> (-5.88%) ⬇️
consensus/src/difficulty.rs 43.03% <0.00%> (-5.81%) ⬇️
vm/resource-viewer/src/lib.rs 0.68% <0.00%> (-5.36%) ⬇️
network-p2p/src/peer_info.rs 45.17% <0.00%> (-4.30%) ⬇️
rpc/server/src/module/contract_rpc.rs 3.73% <0.00%> (-4.25%) ⬇️
vm/resource-viewer/src/fat_type.rs 0.00% <0.00%> (-4.08%) ⬇️
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de7eded...6eb190c. Read the comment docs.

port: 9840
initialDelaySeconds: 10
periodSeconds: 5
timeoutSeconds: 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timeoutSeconds 这个感觉要设置长一些,不然升级的过程中清洗数据,会被判定为超时,然后反复 kill 掉重试.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多久比较合适 10s?

@sanlee42 sanlee42 merged commit d458b70 into master Dec 13, 2021
@sanlee42 sanlee42 deleted the kube_probe branch December 13, 2021 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants