Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark flamegraph save on s3 #3043

Merged
merged 19 commits into from
Nov 25, 2021
Merged

benchmark flamegraph save on s3 #3043

merged 19 commits into from
Nov 25, 2021

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Nov 23, 2021

还需要把AWS_ACCESS_KEY通过secrets提供

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #3043 (e78747e) into master (b07cc33) will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3043      +/-   ##
==========================================
+ Coverage   33.00%   33.24%   +0.24%     
==========================================
  Files         516      516              
  Lines       45976    45976              
  Branches    20966    20966              
==========================================
+ Hits        15168    15278     +110     
+ Misses      16587    16294     -293     
- Partials    14221    14404     +183     
Flag Coverage Δ
unittests 33.24% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
network-p2p/src/transport.rs 15.10% <0.00%> (-9.43%) ⬇️
commons/accumulator/src/tree.rs 47.81% <0.00%> (-7.31%) ⬇️
commons/accumulator/src/tree_store/mock.rs 32.44% <0.00%> (-5.40%) ⬇️
rpc/server/src/rate_limit_middleware.rs 17.08% <0.00%> (-4.87%) ⬇️
types/src/sync_status.rs 53.13% <0.00%> (-4.68%) ⬇️
vm/functional-tests/src/config/global.rs 42.98% <0.00%> (-3.30%) ⬇️
network/src/worker.rs 33.88% <0.00%> (-3.22%) ⬇️
config/src/stratum_config.rs 46.16% <0.00%> (-2.56%) ⬇️
commons/metrics/src/lib.rs 22.50% <0.00%> (-2.50%) ⬇️
commons/stream-task/src/tests.rs 32.94% <0.00%> (-2.40%) ⬇️
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b07cc33...e78747e. Read the comment docs.

@jolestar
Copy link
Member

jolestar commented Nov 24, 2021

https://github.com/starcoinorg/starcoin/runs/4310720756?check_suite_focus=true
报错

bash: ./scripts/flamegraph.sh: No such file or directory

感觉,是不是哪一步把 pwd 给改变了

@nkysg
Copy link
Collaborator Author

nkysg commented Nov 24, 2021

https://github.com/starcoinorg/starcoin/runs/4310720756?check_suite_focus=true 报错

bash: ./scripts/flamegraph.sh: No such file or directory

感觉,是不是哪一步把 pwd 给改变了

我想想看

@nkysg
Copy link
Collaborator Author

nkysg commented Nov 24, 2021

https://github.com/starcoinorg/starcoin/runs/4310720756?check_suite_focus=true 报错
bash: ./scripts/flamegraph.sh: No such file or directory
感觉,是不是哪一步把 pwd 给改变了

我想想看

换了顺序就好了,是不是重置下环境也行

@jolestar
Copy link
Member

https://github.com/starcoinorg/starcoin/runs/4310720756?check_suite_focus=true 报错
bash: ./scripts/flamegraph.sh: No such file or directory
感觉,是不是哪一步把 pwd 给改变了

我想想看

换了顺序就好了,是不是重置下环境也行

可能是 boa-dev/criterion-compare-action@master 这步修改 pwd 了

@nkysg
Copy link
Collaborator Author

nkysg commented Nov 25, 2021

pull request会运行benchmark_pr.yml 按pull request number作为文件夹生成火焰图
https://s3.ap-northeast-1.amazonaws.com/flamegraph.starcoin.org/3043/apply_block.svg
benchmark.yml按照commit_id为文件夹生成火焰图
https://s3.ap-northeast-1.amazonaws.com/flamegraph.starcoin.org/e78747e/apply_block.svg

@nkysg nkysg merged commit deb619f into master Nov 25, 2021
@nkysg nkysg deleted the flamegraph_on_s3 branch November 25, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants