Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[merkle] Support compute root by non-existence proof and add a test #3010

Merged
merged 5 commits into from
Dec 7, 2021

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Nov 4, 2021

验证可以通过 non-existence proof 来计算出该节点写入后的新 root。

初步验证通过,需要增加更多测试。

@jolestar jolestar requested review from ssyuan, nanne007 and nkysg November 4, 2021 14:49
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #3010 (3ad36a5) into master (96e30e3) will increase coverage by 0.02%.
The diff coverage is 32.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3010      +/-   ##
==========================================
+ Coverage   33.31%   33.33%   +0.02%     
==========================================
  Files         515      515              
  Lines       45688    45763      +75     
  Branches    20814    20872      +58     
==========================================
+ Hits        15218    15252      +34     
- Misses      16045    16176     +131     
+ Partials    14425    14335      -90     
Flag Coverage Δ
unittests 33.33% <32.95%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ons/forkable-jellyfish-merkle/src/node_type/mod.rs 73.54% <ø> (-0.68%) ⬇️
...able-jellyfish-merkle/src/jellyfish_merkle_test.rs 18.24% <14.82%> (-0.61%) ⬇️
commons/forkable-jellyfish-merkle/src/proof.rs 65.89% <64.52%> (-0.78%) ⬇️
...m/types/src/account_config/events/config_change.rs 66.67% <0.00%> (-33.33%) ⬇️
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.84%) ⬇️
vm/types/src/transaction/error.rs 3.93% <0.00%> (-15.68%) ⬇️
vm/natives/src/account.rs 14.29% <0.00%> (-7.14%) ⬇️
cmd/starcoin/src/cli_state.rs 47.37% <0.00%> (-5.26%) ⬇️
storage/src/cache_storage/mod.rs 45.00% <0.00%> (-5.00%) ⬇️
vm/natives/src/token.rs 29.55% <0.00%> (-4.54%) ⬇️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 100ab34...3ad36a5. Read the comment docs.

@jolestar jolestar marked this pull request as draft November 5, 2021 09:03
@jolestar jolestar marked this pull request as ready for review November 8, 2021 11:04
@jolestar jolestar requested review from welbon and wubuku December 6, 2021 04:26
@nanne007 nanne007 merged commit c40e370 into master Dec 7, 2021
@nanne007 nanne007 deleted the non_exist_proof branch December 7, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants