[cmd] add a cmd to submit upgrade vm config proposal #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2466 +/- ##
==========================================
- Coverage 33.50% 33.44% -0.06%
==========================================
Files 493 493
Lines 43079 43106 +27
Branches 19585 19608 +23
==========================================
- Hits 14430 14411 -19
- Misses 13645 13677 +32
- Partials 15004 15018 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Benchmark for 6b5d26eClick to view benchmark
|
jolestar
reviewed
Apr 29, 2021
| let genesis_config = net.genesis_config().clone(); | ||
| let min_action_delay = get_dao_config(cli_state)?.min_action_delay; | ||
| let vm_config_upgrade_proposal = | ||
| build_vm_config_upgrade_proposal(genesis_config.vm_config, min_action_delay); |
There was a problem hiding this comment.
genesis_config 的 vm_config 配置之后就不能变了，所以不能从这里去 config 然后提 proposal
There was a problem hiding this comment.
原先的想法是从halley读取config写到Proxima上去。步骤是这样的：先修改halley的config，测试没有问题，再升级到Proxima上。
There was a problem hiding this comment.
原先的想法是从halley读取config写到Proxima上去。步骤是这样的：先修改halley的config，测试没有问题，再升级到Proxima上。
也是个办法。
jolestar
approved these changes
Apr 30, 2021
naughtyvenom
pushed a commit
to naughtyvenom/starcoin
that referenced
this pull request
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.