events: generate event data format for usage in sdks #2458

nanne007 · 2021-04-28T03:11:22Z

No description provided.

codecov · 2021-04-28T03:47:09Z

Codecov Report

Merging #2458 (74eaf49) into master (bbec1ce) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2458      +/-   ##
==========================================
- Coverage   33.64%   33.47%   -0.16%     
==========================================
  Files         492      493       +1     
  Lines       42799    42859      +60     
  Branches    19391    19425      +34     
==========================================
- Hits        14395    14344      -51     
- Misses      13527    13750     +223     
+ Partials    14877    14765     -112

Flag	Coverage Δ
unittests	`33.47% <0.00%> (-0.16%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
dataformat-generator/build.rs	`14.71% <0.00%> (-4.16%)`	⬇️
rpc/server/src/module/chain_rpc.rs	`4.96% <0.00%> (-0.02%)`	⬇️
vm/types/src/account_config/events/block.rs	`0.00% <0.00%> (ø)`
network-rpc/core/src/lib.rs	`23.53% <0.00%> (-5.88%)`	⬇️
vm/vm-runtime/src/data_cache.rs	`66.67% <0.00%> (-3.92%)`	⬇️
sync/src/block_connector/test_illegal_block.rs	`14.68% <0.00%> (-3.34%)`	⬇️
executor/src/stdlib_test/on_chain_config_test.rs	`19.61% <0.00%> (-3.26%)`	⬇️
vm/types/src/access_path.rs	`48.41% <0.00%> (-3.18%)`	⬇️
...ccount_config/resources/module_upgrade_strategy.rs	`42.86% <0.00%> (-2.85%)`	⬇️
vm/types/src/on_chain_resource/epoch.rs	`37.99% <0.00%> (-2.32%)`	⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbec1ce...74eaf49. Read the comment docs.

github-actions · 2021-04-28T03:54:27Z

Benchmark for `2de35fa`

Click to view benchmark

Test	PR Benchmark	Master Benchmark	%
accumulator_append	2.2±0.26ms	2.3±0.26ms	-4.35%
block_apply/block_apply_10	394.8±6.58ms	387.6±5.75ms	+1.86%
block_apply/block_apply_1000	40.0±0.44s	39.8±0.37s	+0.50%
get_with_proof/db_store	38.3±0.54µs	38.3±0.29µs	0.00%
get_with_proof/mem_store	32.0±0.33µs	31.9±0.29µs	+0.31%
put_and_commit/db_store/1	1270.8±76.22µs	1181.4±62.65µs	+7.57%
put_and_commit/db_store/10	2.2±0.35ms	2.3±0.33ms	-4.35%
put_and_commit/db_store/100	9.2±0.56ms	9.3±0.48ms	-1.08%
put_and_commit/db_store/5	1874.9±151.67µs	1874.3±146.45µs	+0.03%
put_and_commit/db_store/50	5.4±0.43ms	5.5±0.56ms	-1.82%
put_and_commit/mem_store/1	63.0±5.55µs	63.3±5.53µs	-0.47%
put_and_commit/mem_store/10	587.2±48.06µs	585.7±45.25µs	+0.26%
put_and_commit/mem_store/100	5.7±0.81ms	5.8±0.81ms	-1.72%
put_and_commit/mem_store/5	298.4±24.85µs	297.0±24.00µs	+0.47%
put_and_commit/mem_store/50	2.9±0.18ms	2.9±0.18ms	0.00%
query_block/query_block_in(10)_times(100)	2.7±0.06ms	2.7±0.03ms	0.00%
query_block/query_block_in(10)_times(1000)	26.9±0.33ms	26.8±0.23ms	+0.37%
query_block/query_block_in(10)_times(10000)	266.8±2.24ms	267.3±5.03ms	-0.19%
query_block/query_block_in(1000)_times(100)	912.5±3.77µs	909.5±3.67µs	+0.33%
query_block/query_block_in(1000)_times(1000)	9.1±0.05ms	9.1±0.04ms	0.00%
query_block/query_block_in(1000)_times(10000)	92.2±0.71ms	91.6±0.43ms	+0.66%
storage_transaction	43.2±3.60ms	45.8±3.15ms	-5.68%
vm/transaction_execution/1	308.8±4.11ms	309.2±4.89ms	-0.13%
vm/transaction_execution/10	103.4±1.20ms	103.6±1.89ms	-0.19%
vm/transaction_execution/20	97.6±0.36ms	97.5±0.27ms	+0.10%
vm/transaction_execution/5	123.6±1.00ms	123.8±0.99ms	-0.16%
vm/transaction_execution/50	113.0±0.21ms	113.0±0.37ms	0.00%

github-actions · 2021-04-28T04:33:57Z

Benchmark for `1b98373`

Click to view benchmark

Test	PR Benchmark	Master Benchmark	%
accumulator_append	2.4±0.13ms	2.4±0.12ms	0.00%
block_apply/block_apply_10	423.8±5.62ms	421.0±13.66ms	+0.67%
block_apply/block_apply_1000	43.4±0.73s	42.7±0.34s	+1.64%
get_with_proof/db_store	38.1±0.74µs	38.9±0.47µs	-2.06%
get_with_proof/mem_store	31.6±0.59µs	31.6±0.24µs	0.00%
put_and_commit/db_store/1	1407.6±73.61µs	1388.3±85.57µs	+1.39%
put_and_commit/db_store/10	2.5±0.55ms	2.5±0.51ms	0.00%
put_and_commit/db_store/100	9.6±1.02ms	9.7±1.55ms	-1.03%
put_and_commit/db_store/5	2.0±0.20ms	2.0±0.21ms	0.00%
put_and_commit/db_store/50	5.9±0.94ms	6.0±1.06ms	-1.67%
put_and_commit/mem_store/1	63.1±5.55µs	63.5±5.54µs	-0.63%
put_and_commit/mem_store/10	590.3±46.22µs	592.1±48.18µs	-0.30%
put_and_commit/mem_store/100	5.7±0.81ms	5.8±0.82ms	-1.72%
put_and_commit/mem_store/5	298.2±23.90µs	299.8±23.79µs	-0.53%
put_and_commit/mem_store/50	2.9±0.18ms	2.9±0.18ms	0.00%
query_block/query_block_in(10)_times(100)	2.7±0.04ms	2.7±0.04ms	0.00%
query_block/query_block_in(10)_times(1000)	26.9±0.52ms	27.0±0.78ms	-0.37%
query_block/query_block_in(10)_times(10000)	270.2±4.05ms	266.2±4.64ms	+1.50%
query_block/query_block_in(1000)_times(100)	954.6±3.69µs	922.3±5.58µs	+3.50%
query_block/query_block_in(1000)_times(1000)	9.4±0.09ms	9.1±0.04ms	+3.30%
query_block/query_block_in(1000)_times(10000)	95.2±0.56ms	90.4±0.41ms	+5.31%
storage_transaction	51.0±3.58ms	52.0±3.83ms	-1.92%
vm/transaction_execution/1	308.3±3.91ms	307.2±1.10ms	+0.36%
vm/transaction_execution/10	103.3±0.63ms	103.3±0.75ms	0.00%
vm/transaction_execution/20	98.2±2.16ms	98.5±2.46ms	-0.30%
vm/transaction_execution/5	123.4±0.31ms	123.2±0.38ms	+0.16%
vm/transaction_execution/50	113.3±0.82ms	113.3±1.32ms	0.00%

jolestar

奇怪，没看到哪里的改动影响集成测试呀

github-actions · 2021-04-28T15:25:34Z

Benchmark for `660ef91`

Click to view benchmark

Test	PR Benchmark	Master Benchmark	%
accumulator_append	2.2±0.39ms	2.2±0.11ms	0.00%
block_apply/block_apply_10	429.1±12.13ms	403.1±8.33ms	+6.45%
block_apply/block_apply_1000	41.2±0.52s	40.8±0.42s	+0.98%
get_with_proof/db_store	38.7±0.29µs	39.3±0.37µs	-1.53%
get_with_proof/mem_store	31.7±0.28µs	31.9±0.35µs	-0.63%
put_and_commit/db_store/1	1355.8±78.91µs	1330.5±91.51µs	+1.90%
put_and_commit/db_store/10	2.4±0.42ms	2.4±0.44ms	0.00%
put_and_commit/db_store/100	9.4±0.92ms	9.5±0.98ms	-1.05%
put_and_commit/db_store/5	1962.2±231.24µs	2.0±0.21ms	-1.89%
put_and_commit/db_store/50	5.6±0.87ms	5.7±0.92ms	-1.75%
put_and_commit/mem_store/1	63.4±5.57µs	62.9±5.56µs	+0.79%
put_and_commit/mem_store/10	587.6±46.49µs	584.1±47.27µs	+0.60%
put_and_commit/mem_store/100	5.8±0.82ms	5.7±0.81ms	+1.75%
put_and_commit/mem_store/5	297.1±24.31µs	296.2±24.45µs	+0.30%
put_and_commit/mem_store/50	2.9±0.18ms	2.9±0.18ms	0.00%
query_block/query_block_in(10)_times(100)	2.7±0.05ms	2.7±0.07ms	0.00%
query_block/query_block_in(10)_times(1000)	26.8±0.55ms	26.7±0.43ms	+0.37%
query_block/query_block_in(10)_times(10000)	266.0±3.98ms	267.7±4.87ms	-0.64%
query_block/query_block_in(1000)_times(100)	917.9±3.30µs	907.1±5.38µs	+1.19%
query_block/query_block_in(1000)_times(1000)	9.2±0.04ms	9.1±0.05ms	+1.10%
query_block/query_block_in(1000)_times(10000)	92.1±0.33ms	91.0±0.39ms	+1.21%
storage_transaction	47.1±3.18ms	47.5±4.19ms	-0.84%
vm/transaction_execution/1	308.0±0.61ms	307.2±1.04ms	+0.26%
vm/transaction_execution/10	103.2±0.22ms	103.1±0.50ms	+0.10%
vm/transaction_execution/20	97.9±0.88ms	97.3±0.30ms	+0.62%
vm/transaction_execution/5	123.6±0.33ms	124.2±1.77ms	-0.48%
vm/transaction_execution/50	113.3±0.63ms	113.0±0.65ms	+0.27%

* events: generate event data format for usage in sdks * rpc: return max block count instead of error * fix test

events: generate event data format for usage in sdks

6c157d5

nanne007 requested review from sanlee42 and jolestar April 28, 2021 03:11

rpc: return max block count instead of error

649fcdf

nanne007 requested a review from fanngyuan April 28, 2021 04:00

jolestar reviewed Apr 28, 2021

View reviewed changes

jolestar approved these changes Apr 28, 2021

View reviewed changes

fix test

74eaf49

nanne007 merged commit 99f0392 into master Apr 28, 2021

nanne007 deleted the generate-onchain-events branch April 28, 2021 23:48

naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021

events: generate event data format for usage in sdks (starcoinorg#2458)

31eef5f

* events: generate event data format for usage in sdks * rpc: return max block count instead of error * fix test

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

events: generate event data format for usage in sdks #2458

events: generate event data format for usage in sdks #2458

nanne007 commented Apr 28, 2021

codecov bot commented Apr 28, 2021 •

edited

Loading

github-actions bot commented Apr 28, 2021

github-actions bot commented Apr 28, 2021

jolestar left a comment

github-actions bot commented Apr 28, 2021

events: generate event data format for usage in sdks #2458

events: generate event data format for usage in sdks #2458

Conversation

nanne007 commented Apr 28, 2021

codecov bot commented Apr 28, 2021 • edited Loading

Codecov Report

github-actions bot commented Apr 28, 2021

Benchmark for 2de35fa

github-actions bot commented Apr 28, 2021

Benchmark for 1b98373

jolestar left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 28, 2021

Benchmark for 660ef91

codecov bot commented Apr 28, 2021 •

edited

Loading

Benchmark for `2de35fa`

Benchmark for `1b98373`

Benchmark for `660ef91`