Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): make host path for pip cache optional #1306

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

jialeicui
Copy link
Contributor

Description

Make host path for pip cache optional

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #1306 (e7403a5) into main (204976b) will decrease coverage by 10.79%.
The diff coverage is 87.50%.

@@              Coverage Diff              @@
##               main    #1306       +/-   ##
=============================================
- Coverage     75.90%   65.10%   -10.80%     
  Complexity     1287     1287               
=============================================
  Files           289      226       -63     
  Lines         13413     6374     -7039     
  Branches        655      657        +2     
=============================================
- Hits          10181     4150     -6031     
+ Misses         3009     2000     -1009     
- Partials        223      224        +1     
Flag Coverage Δ
controller 65.10% <87.50%> (+0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...i/starwhale/mlops/schedule/k8s/K8sJobTemplate.java 84.61% <87.50%> (-0.17%) ⬇️
client/starwhale/utils/fs.py
client/starwhale/base/uri.py
client/starwhale/api/_impl/dataset/loader.py
client/starwhale/base/bundle_copy.py
client/starwhale/base/mixin.py
client/starwhale/core/eval/store.py
client/starwhale/api/dataset.py
client/starwhale/core/dataset/store.py
client/starwhale/consts/env.py
... and 54 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit 2761b22 into star-whale:main Sep 27, 2022
@jialeicui jialeicui deleted the make-pip-cache-opt branch September 27, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants