Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): support force remove for model/dataset/runtime/eval #1261

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Sep 20, 2022

Description

use --force to remove objects directly which cannot recover.

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #1261 (00b49ff) into main (778cab1) will increase coverage by 11.80%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #1261       +/-   ##
=============================================
+ Coverage     73.84%   85.64%   +11.80%     
=============================================
  Files           287       62      -225     
  Lines         13378     7036     -6342     
  Branches        651        0      -651     
=============================================
- Hits           9879     6026     -3853     
+ Misses         3277     1010     -2267     
+ Partials        222        0      -222     
Flag Coverage Δ
controller ?
standalone 85.64% <100.00%> (+0.01%) ⬆️
unittests 85.64% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/model/store.py 100.00% <ø> (ø)
client/starwhale/core/runtime/store.py 100.00% <ø> (ø)
client/starwhale/base/bundle.py 92.05% <100.00%> (+0.68%) ⬆️
client/starwhale/base/store.py 96.18% <100.00%> (+0.08%) ⬆️
client/starwhale/core/dataset/model.py 72.77% <100.00%> (+0.41%) ⬆️
client/starwhale/core/eval/model.py 77.77% <100.00%> (+0.30%) ⬆️
client/starwhale/core/model/model.py 85.34% <100.00%> (-0.25%) ⬇️
client/starwhale/core/runtime/model.py 92.85% <100.00%> (-0.06%) ⬇️
...java/ai/starwhale/mlops/storage/env/AliyunEnv.java
...ps/domain/swmp/po/SwModelPackageVersionEntity.java
... and 223 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit f1bf27a into star-whale:main Sep 22, 2022
@tianweidut tianweidut deleted the enhance/client-remove branch April 17, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants