Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(client): fix failed job status exception raise #1248

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

goldenxinxing
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the bug 🐛 Something isn't working label Sep 19, 2022
@goldenxinxing goldenxinxing self-assigned this Sep 19, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #1248 (8b766d0) into main (d9c77bb) will increase coverage by 11.51%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1248       +/-   ##
=============================================
+ Coverage     74.17%   85.69%   +11.51%     
=============================================
  Files           284       62      -222     
  Lines         13159     6996     -6163     
  Branches        641        0      -641     
=============================================
- Hits           9761     5995     -3766     
+ Misses         3184     1001     -2183     
+ Partials        214        0      -214     
Flag Coverage Δ
controller ?
standalone 85.69% <ø> (ø)
unittests 85.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/model/model.py 85.59% <ø> (ø)
...ps/domain/system/resourcepool/bo/ResourcePool.java
...e/mlops/domain/swds/converter/SwdsVoConvertor.java
.../java/ai/starwhale/mlops/storage/fs/AliyunEnv.java
...a/ai/starwhale/mlops/memory/impl/SwByteBuffer.java
...e/mlops/configuration/security/JwtLoginFilter.java
.../ai/starwhale/mlops/domain/user/RoleConvertor.java
...ava/ai/starwhale/mlops/datastore/ColumnSchema.java
...ava/ai/starwhale/mlops/common/util/RandomUtil.java
...ai/starwhale/mlops/domain/job/cache/JobLoader.java
... and 213 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut
Copy link
Member

@goldenxinxing add some ut for the job status and exceptions?

@tianweidut tianweidut merged commit af492fb into star-whale:main Sep 19, 2022
@tianweidut tianweidut changed the title fix(client): raise exception when error bug(client): fix job failed status exception raise Sep 19, 2022
@tianweidut tianweidut changed the title bug(client): fix job failed status exception raise bug(client): fix failed job status exception raise Sep 19, 2022
@goldenxinxing goldenxinxing deleted the fix/exit_exception_bug branch April 27, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants