Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(controller): support virtual host path configuration #1178

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Sep 13, 2022

Description

Resolve the virtual host issue
ref: https://help.aliyun.com/document_detail/64919.html

Relates to #1157

File "/opt/starwhale/swmp/export/venv/lib/python3.8/site-packages/botocore/client.py", line 745, in _make_api_call
    raise error_class(parsed_response, operation_name)
          │           │                └ 'GetObject'
          │           └ {'Error': {'Code': 'SecondLevelDomainForbidden', 'Message': 'Please use virtual hosted style to access.'}, 'ResponseMetadata'...
          └ <class 'botocore.exceptions.ClientError'>

botocore.exceptions.ClientError: An error occurred (SecondLevelDomainForbidden) when calling the GetObject operation: Please use virtual hosted style to access.

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui marked this pull request as draft September 13, 2022 05:18
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #1178 (da06834) into main (5547127) will increase coverage by 0.06%.
The diff coverage is 52.17%.

❗ Current head da06834 differs from pull request most recent head 53929d9. Consider uploading reports for the commit 53929d9 to get more accurate results

@@             Coverage Diff              @@
##               main    #1178      +/-   ##
============================================
+ Coverage     75.86%   75.93%   +0.06%     
- Complexity      883      897      +14     
============================================
  Files           204      206       +2     
  Lines         10828    10866      +38     
  Branches        409      412       +3     
============================================
+ Hits           8215     8251      +36     
- Misses         2466     2468       +2     
  Partials        147      147              
Flag Coverage Δ
controller 66.61% <50.00%> (+0.25%) ⬆️
standalone 81.22% <100.00%> (+<0.01%) ⬆️
unittests 81.22% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mlops/storage/configuration/StorageProperties.java 0.00% <0.00%> (ø)
.../ai/starwhale/mlops/storage/fs/FileStorageEnv.java 83.33% <0.00%> (+83.33%) ⬆️
client/starwhale/core/dataset/store.py 87.08% <100.00%> (+0.09%) ⬆️
.../java/ai/starwhale/mlops/storage/fs/AliyunEnv.java 100.00% <100.00%> (ø)
...va/ai/starwhale/mlops/storage/fs/BotoS3Config.java 100.00% <100.00%> (ø)
...main/java/ai/starwhale/mlops/storage/fs/S3Env.java 100.00% <100.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jialeicui jialeicui force-pushed the support-virtual-host-path branch from d286250 to 3389cde Compare September 13, 2022 05:22
@jialeicui jialeicui force-pushed the support-virtual-host-path branch from da06834 to 53929d9 Compare September 13, 2022 06:03
@jialeicui jialeicui marked this pull request as ready for review September 13, 2022 06:06
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tianweidut
Copy link
Member

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit cfd17ee into star-whale:main Sep 13, 2022
@jialeicui jialeicui deleted the support-virtual-host-path branch September 13, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants