-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(controller): support virtual host path configuration #1178
enhance(controller): support virtual host path configuration #1178
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1178 +/- ##
============================================
+ Coverage 75.86% 75.93% +0.06%
- Complexity 883 897 +14
============================================
Files 204 206 +2
Lines 10828 10866 +38
Branches 409 412 +3
============================================
+ Hits 8215 8251 +36
- Misses 2466 2468 +2
Partials 147 147
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
d286250
to
3389cde
Compare
da06834
to
53929d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@jialeicui https://github.com/star-whale/starwhale/blob/main/client/starwhale/core/dataset/store.py#L363 does this s3 config change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Resolve the virtual host issue
ref: https://help.aliyun.com/document_detail/64919.html
Relates to #1157
Modules
Checklist