Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client):Remove redundant URI parse logic #1145

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Sep 7, 2022

Description

Remove redundant logic

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the chore 🛎️ some tiny change label Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #1145 (b578012) into main (ba13bd2) will increase coverage by 8.16%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1145      +/-   ##
============================================
+ Coverage     73.66%   81.83%   +8.16%     
============================================
  Files           195       63     -132     
  Lines         10446     6908    -3538     
  Branches        387        0     -387     
============================================
- Hits           7695     5653    -2042     
+ Misses         2635     1255    -1380     
+ Partials        116        0     -116     
Flag Coverage Δ
controller ?
standalone 81.83% <100.00%> (+0.21%) ⬆️
unittests 81.83% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/base/uri.py 95.06% <100.00%> (-0.07%) ⬇️
...e/mlops/domain/storage/StoragePathCoordinator.java
.../java/ai/starwhale/mlops/common/util/HttpUtil.java
...arwhale/mlops/domain/swds/upload/SwdsUploader.java
...ai/starwhale/mlops/memory/SwBufferInputStream.java
.../task/status/watchers/TaskWatcherForJobStatus.java
...va/ai/starwhale/mlops/resulting/ResultQuerier.java
...a/ai/starwhale/mlops/common/util/JwtTokenUtil.java
...c/main/java/ai/starwhale/mlops/common/RegExps.java
...hale/mlops/schedule/k8s/ResourceOverwriteSpec.java
... and 124 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut merged commit 5b92ec3 into star-whale:main Sep 8, 2022
@goldenxinxing goldenxinxing deleted the chore/optimise_uri_parse branch May 6, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants