Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): do not cache unfinished evaluation #1074

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

jialeicui
Copy link
Contributor

Description

Access the evaluation list when the job is unfinished, the status will be cached, and never update until controller restart.

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added bug 🐛 Something isn't working controller 🏘️ labels Aug 30, 2022
@jialeicui jialeicui requested a review from dreamlandliu August 30, 2022 08:35
Copy link
Contributor

@dreamlandliu dreamlandliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dreamlandliu dreamlandliu merged commit 821159c into star-whale:main Aug 30, 2022
@jialeicui jialeicui deleted the fix-eva-status branch August 30, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working controller 🏘️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants