Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): job scheduler #1042

Merged
merged 18 commits into from
Sep 5, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Aug 28, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added bug 🐛 Something isn't working refactor 🐛 refactor code labels Aug 28, 2022
@goldenxinxing goldenxinxing self-assigned this Aug 28, 2022
@tianweidut
Copy link
Member

use python graphlib as the dag fundamental?

cc @goldenxinxing

@tianweidut tianweidut self-requested a review September 1, 2022 05:47
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1042 (0cc7040) into main (0db5b10) will increase coverage by 2.09%.
The diff coverage is 97.73%.

@@            Coverage Diff             @@
##             main    #1042      +/-   ##
==========================================
+ Coverage   79.52%   81.61%   +2.09%     
==========================================
  Files          62       63       +1     
  Lines        6807     6880      +73     
==========================================
+ Hits         5413     5615     +202     
+ Misses       1394     1265     -129     
Flag Coverage Δ
standalone 81.61% <97.73%> (+2.09%) ⬆️
unittests 81.61% <97.73%> (+2.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/eval/executor.py 91.73% <ø> (ø)
client/starwhale/core/model/view.py 69.31% <ø> (ø)
client/starwhale/core/model/model.py 86.28% <75.00%> (-0.39%) ⬇️
client/starwhale/core/model/default_handler.py 93.33% <80.00%> (+48.17%) ⬆️
client/starwhale/core/job/model.py 96.72% <98.00%> (+62.51%) ⬆️
client/starwhale/api/_impl/job.py 98.86% <100.00%> (+4.26%) ⬆️
client/starwhale/api/_impl/model.py 88.28% <100.00%> (+3.88%) ⬆️
client/starwhale/core/job/dag.py 100.00% <100.00%> (ø)
client/starwhale/core/job/scheduler.py 100.00% <100.00%> (+68.42%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit d4607cb into star-whale:main Sep 5, 2022
@goldenxinxing goldenxinxing deleted the fix/refactor_job_scheduler branch September 13, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working refactor 🐛 refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants