Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): fix dataset uri download error #1028

Merged
merged 2 commits into from
Aug 28, 2022
Merged

fix(controller): fix dataset uri download error #1028

merged 2 commits into from
Aug 28, 2022

Conversation

anda-ren
Copy link
Member

Description

  • change offset/size parameter type to string
  • adapt to relative uri

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added this to the v0.3 milestone Aug 28, 2022
@anda-ren anda-ren requested a review from waynelwz August 28, 2022 05:17
@anda-ren anda-ren self-assigned this Aug 28, 2022
waynelwz
waynelwz approved these changes Aug 28, 2022
View reviewed changes
Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit c88a05b into star-whale:main Aug 28, 2022
@anda-ren anda-ren deleted the unify_ds_schema branch September 2, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynelwz waynelwz waynelwz approved these changes

Assignees

@anda-ren anda-ren

Labels
controller 🏘️
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anda-ren @waynelwz