Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.9 and 3.10 #1897

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Support Python 3.9 and 3.10 #1897

merged 5 commits into from
Oct 24, 2023

Conversation

yifanmai
Copy link
Collaborator

@yifanmai yifanmai commented Oct 13, 2023

This updates python_requires of the package. It also runs CI on Python 3.8 through 3.10. This triples the number of GitHub Action minutes used, which should hopefully not be a problem.

Fixes #1511

@yifanmai yifanmai changed the title DO NOT MERGE: Run CI with multiple versions of Python Support Python 3.9 and 3.10 Oct 14, 2023
@msaroufim msaroufim self-requested a review October 16, 2023 19:30
Copy link
Contributor

@JosselinSomervilleRoberts JosselinSomervilleRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JosselinSomervilleRoberts
Copy link
Contributor

Out of curiosity, any reason why we are not supporting 3.11?

@yifanmai
Copy link
Collaborator Author

Yes, HELM doesn't work on Python 3.11 yet. I filed a new issue #1913 and added more details there.

@yifanmai yifanmai merged commit c2fbf61 into main Oct 24, 2023
@yifanmai yifanmai deleted the yifanmai/fix-upgrade-python branch October 24, 2023 17:35
brianwgoldman pushed a commit that referenced this pull request Oct 24, 2023
brianwgoldman pushed a commit that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support newer versions of Python
3 participants