Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React near feature parity #1893

Merged
merged 16 commits into from
Oct 24, 2023
Merged

React near feature parity #1893

merged 16 commits into from
Oct 24, 2023

Conversation

farzaank
Copy link
Contributor

@farzaank farzaank commented Oct 11, 2023

Fixes bugs, inconsistencies, and problems with React front end.

The ultimate goal of this PR is to create a React site that is as similar to the existing one as possible, as a foundation for the redesigned site.

Changes include the following

  • Refactor of components directory to have subdirectories for components with multiple file names
    • Currently all extra files are tests, so alternatively we can create a Tests directory, but either way tests should not be sitting in the same main directory
  • Implemented footer component as home for version number (new design doesn't allow version to live in header)
  • Added version # (currently not displayed on React site)
  • Landing page fixed
    • Fix logo sizing
    • Fix button styling
    • Fix broken links
  • Move charts to bottom of subsites, for consistency with current layout
  • Comment out subsites' chart view until we can make it reflect the differences between metrics

@yifanmai
Copy link
Collaborator

Looks promising! Let me know when this is ready for review, thanks!

@farzaank farzaank marked this pull request as ready for review October 13, 2023 20:11
@farzaank farzaank requested a review from yifanmai October 13, 2023 20:12
@farzaank
Copy link
Contributor Author

Looks promising! Let me know when this is ready for review, thanks!

@yifanmai Just bumping my request for review! Let me know when you get a chance to check this out.

Copy link
Collaborator

@yifanmai yifanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@yifanmai yifanmai merged commit 020255d into main Oct 24, 2023
3 checks passed
@yifanmai yifanmai deleted the farzaan/initial-react-fixes branch October 24, 2023 22:23
brianwgoldman pushed a commit that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants