-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix install error from latest version of repo #1617
Conversation
Also, I see an |
I also noted that sometimes the |
The upstream issue was updated with a note that we can instead pin |
That does not work for spacy 3.2.4. It mentions in that issue that the fix is for Moreover, when I try to fix
So, spacy 3.2.4 depends on pydantic!=1.8, !=1.8.1, <1.9.0 and >=1.7.4. Thus, unless we want to upgrade spacy in addition to pydantic, I don't think that fix will work, sorry! |
Can we also upgrade Spacy to v3.4? Are there any breaking changes? |
Ah, yes, we can! That works. We don't even need to pin the pydantic version since those versions of spacy automatically install a high enough version. Sorry, I didn't know if updating spacy was an option. |
Fixes issue #1616.
This PR does the following:
pip install -e .
works again. (It was missingsimple-slurm
and an update to thetokenizers
version.)Note on 1): The issue found in #1616 is documented on spaCy's repo here. In short, they have a temporary workaround to use
typing-extensions<4.6.0
, which is what I use here.