Add test for loading config without warnings #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you seen the test fail with an intentionally broken config? If so, then I'd say this is plenty elegant! |
|
Yeah - I re-created the previous EMABLED typo, messed around with various rubocop config objects until something failed (looked for validation/errors objects at first, settled on this), then confirmed it passed when corrected. |
|
Nice! Then it certainly won't hurt. And if it somehow does we can always delete it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: #663 (comment)
This works in the sense that if I re-create that typo this test fails, and if I leave the typo fixed this passes, so it presumably would have caught that issue.
I'm not super-familiar with rubocop internals, and am very open to feedback here on more elegǎnt way to capture this. I was expecting to be able to either have a validation object with an activemodel-style
errorsarray to assert against, and/or be able to just let this run and have theValidationErrorbe raised - but I think that's swallowed either somewhere within rubocop or somewhere in test harness.