Allow specifying a working directory #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Does it work? |
|
I created this PR prematurely, I'm testing it on a test repo now, will update here when I'm done. |
wjessop
force-pushed
the
allow_running_standardrb_in_a_subdir
branch
from
4dd2d7e to
2a912df
Compare
|
@searls OK, ready for review! |
|
Seems legit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow running standardrb and the commands to set it up in a subdirectory of a repo, allowing for use in monorepos and other weird repo layouts. Mimics the support for a working directory in reviewdog/action-rubocop.
Tested with code in the root of an app, and with the code in a subdir using the new functionality. See the action runs for those repos.
Fixes #21