Fix complex matrix division miscompilation #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveBronder
approved these changes
May 3, 2024
| @@ -241,6 +251,8 @@ and lower_operator_app op es_in = | |||
| | Minus -> lower_binary_op Subtract "stan::math::subtract" es | |||
| | Times -> lower_binary_op Multiply "stan::math::multiply" es | |||
| | Divide | IntDivide -> | |||
| (* XXX: This conditional is probably a sign that we need to rethink how we store Operators | |||
There was a problem hiding this comment.
What is XXX? Should this just be NOTE:
There was a problem hiding this comment.
We've used XXX as basically a FIXME, e.g.
stanc3/src/middle/Internal_fun.ml
Lines 14 to 15 in 9e9953f
stanc3/src/middle/Stan_math_signatures.ml
Lines 179 to 180 in 9e9953f
I'm not sure when it started, just that I'm pretty sure it was before my time.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1421 +/- ##
==========================================
+ Coverage 89.81% 89.83% +0.01%
==========================================
Files 63 63
Lines 10480 10484 +4
==========================================
+ Hits 9413 9418 +5
+ Misses 1067 1066 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Release notes
Fixed an issue where
operator/was not generating the correct C++ for complex linear algebra types.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)