Cleanup deprecations machinery before 2.35 #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveBronder
approved these changes
May 2, 2024
src/frontend/Canonicalize.ml
Outdated
Comment on lines
134
to
136
| if settings.deprecations then remove_unneeded_forward_decls program | ||
| (* NB: currently no other deprecated syntax/functions, so no need to walk tree *) | ||
| (* |> map_program replace_deprecated_stmt *) |
There was a problem hiding this comment.
I think we can just remove this code + comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Release notes
Removed code following the last round of syntax deprecations that is currently scheduled. The final one (use of
realvalues in conditionals) is now a type error and can no longer be automatically canonicalized.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)