Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated _log() probability functions. (Breaking change; bump major version) #2995

Merged

Conversation

syclik
Copy link
Member

@syclik syclik commented Jan 3, 2024

Summary

This PR removes all the deprecated _log() probability functions.

As a consequence, many of the tests needed to be updated.

Tests

I tried to catch all the tests and update them appropiately.

All the log_matches_lpdf and log_matches_lpmf tests are now gone!

Side Effects

This is a breaking change since functions that existed are now removed.

Release notes

Removing deprecated _log distribution functions. Please use _lpdf or _lpmf functions instead.

Checklist

  • Copyright holder: Daniel Lee

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@SteveBronder
Copy link
Collaborator

I'm for this but let's merge it after the current release in two weeks so we have a cycle to see if anything breaks (though I think this should be a fine change)

@syclik
Copy link
Member Author

syclik commented Jan 3, 2024

Absolutely! There's no rush. I just had time and wanted to work on it. I'm relying on the CI machinery.

@syclik syclik force-pushed the feature/remove-deprecated-log-functions branch from 5cf7515 to f4fa3e3 Compare January 3, 2024 21:43
@syclik syclik force-pushed the feature/remove-deprecated-log-functions branch from f4fa3e3 to 30ec9d7 Compare January 3, 2024 22:14
@syclik
Copy link
Member Author

syclik commented Jan 3, 2024

(It should definitely go after the release is done.)

@syclik syclik force-pushed the feature/remove-deprecated-log-functions branch 2 times, most recently from ddd12a3 to 81318e6 Compare January 5, 2024 00:41
@syclik syclik force-pushed the feature/remove-deprecated-log-functions branch from fbe1fe6 to 421fb4a Compare January 6, 2024 21:17
@SteveBronder SteveBronder mentioned this pull request Mar 1, 2024
@SteveBronder SteveBronder changed the base branch from develop to 5.0-breaking-changes April 2, 2024 16:26
@SteveBronder SteveBronder changed the base branch from 5.0-breaking-changes to develop April 2, 2024 16:34
@SteveBronder
Copy link
Collaborator

Once the merge conflict is resolved I'm cool approving this and merging it to the 5.0 branch.

Once the 5.0 branch has another PR in it let's open a PR up for it so the tests go off for the 5.0 branch

@syclik syclik added the breaking change Requires a breaking change to the Math library label Apr 13, 2024
@syclik syclik changed the base branch from develop to 5.0-breaking-changes April 13, 2024 01:17
@syclik
Copy link
Member Author

syclik commented Apr 15, 2024

Just fixed the merge conflict.

The 5.0 branch doesn't have continuous integration in place, unfortunately.

@SteveBronder
Copy link
Collaborator

Lets start merging to it and open a PR for the 5.0 branch

@SteveBronder SteveBronder merged commit 5827e5b into 5.0-breaking-changes Apr 18, 2024
@SteveBronder SteveBronder mentioned this pull request Apr 18, 2024
7 tasks
@WardBrian WardBrian deleted the feature/remove-deprecated-log-functions branch August 5, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Requires a breaking change to the Math library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants