Add glossary page to package documentation #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 94.31% 94.31%
=======================================
Files 15 15
Lines 1197 1197
=======================================
Hits 1129 1129
Misses 68 68
Continue to review full report at Codecov.
|
|
Looks good. I made some additional doc edits also to some other files. If they are ok for you, then you can merge. |
avehtari
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@avehtari I've added a page to the doc with your definitions (minor edits). It will be available from R using
help("loo-glossary")and once released it will be available athttps://mc-stan.org/loo/reference/loo-glossary (not live yet) so we could link to it from anywhere.
You can ignore all the files in the PR except
loo-glossary.R. The others are just other doc pages that got regenerated.fixes issue #81