Scheduled wheel building not working

[riddell-stan]

The BUILD_COMMIT variable is not being set, see https://github.com/stan-dev/httpstan-wheels/runs/1560819086?check_suite_focus=true.

[ahartikainen]

I think this should fix the problem: git fetch --tags

echo "BUILD_COMMIT=$(cd httpstan && git fetch --tags && git tag --sort version:refname | tail -1)" >> $GITHUB_ENV

[riddell-stan]

Interesting. Do you know why it would work without `git fetch --tags` on pull requests and on pushes but not in this `scheduled` run?

…

On 12/16/20 2:34 AM, Ari Hartikainen wrote: I think this should fix the problem: |git fetch --tags| |echo "BUILD_COMMIT=$(cd httpstan && git fetch --tags && git tag --sort version:refname | tail -1)" >> $GITHUB_ENV | — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#68 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJQUBVXHIHJ5AUPXMQ2WVN3SVBPHTANCNFSM4U5H6EPQ>.

[ahartikainen]

I have no idea. It will also fails with forks.

I think some default settings change depending how CI is triggered.

[riddell-stan]

I think actions/checkout#217 explains what is going on.

I'm reopening this issue because the current solution involves a subshell doing a ton of work. I think we should have a step where we fetch the tags separately, akin to this, perhaps, actions/checkout#217 (comment)

[riddell-stan]

git fetch --tags will, as I understand it, fetch the entire history. Is that what we want?

--tags

Fetch all tags from the remote (i.e., fetch remote tags refs/tags/*
           into local tags with the same name), in addition to whatever else
           would otherwise be fetched. 

[ahartikainen]

I liked the PR solution. It does add more work for the engine, but I think it is fine.