Migrate to Leaflet

[mojodna]

Potential plugins to use to achieve the picture-in-picture effect:

https://github.com/bbecquet/Leaflet.MagnifyingGlass - seems to allow fixed coordinates, but not fixed window locations
https://github.com/turban/Leaflet.Sync - used for MapStack, but unclear how to initially correctly align the inner windows

[standardpixel]

I wonder it it would be simpler to define bounding boxes on the viewport and simply change the src attribute on the tile element

[mojodna]

I'm referring to this treatment:

Changing the src attribute seems like it would either result in choppiness or movement rather than masking.

[standardpixel]

I think there might be a way to hook into the bit of Leaflet which calls the tiles and just override the template. Just a theory but it would be way quicker and simpler if so.

at some point I'll try and make it work on Codepen

[standardpixel]

On second thought, I guess making it tile constrained would limit it too much

[mojodna]

Let's start with just the full-screen views.

/cc @sconnelley

[sconnelley]

Oh this is quite extensive :-)

[danrademacher]

So this work would be billed to Knight, right @mojodna?

[mojodna]

@sconnelley have a look at the picture-in-picture stuff to see what you think--if it's going to be way complicated (and you can't come up with uses for solutions down the line), step away and we'll bug @stamen/art for an alternate solution.

The higher value piece is just updating the full-screen views--those seem like they should be more straightforward, but I could be missing something.

I was disappointed that there doesn't appear to be anything that does this already. I'd be curious to hear/read your explanation of how the current system works.

@danrademacher yup.

[sconnelley]

Well I have maps.stamen.com mainly converted to Leaflet. Just need to figure out a few minor things and do some more testing but it's pretty close to being done.
I'm retaining the PIP functionality the Shawn Allen implemented which seems to work pretty good. @mojodna is there something wrong in the current PIP functionality?

[mojodna]

Not at all. Starting with minimal Leaflet knowledge (and unaware of how the data attributes worked), I went hunting for plugins that did the same. What you did sounds way better!

Nice!

[mojodna]

FYI, this is how I'm supporting retina tiles within tessera:

https://github.com/mojodna/tessera/blob/master/public/index.html#L64-L74

(Ignore getParameterByName--that was a debugging addition from Brandon)

[sconnelley]

@mojodna - Are all stamen tiles retina-ized?

[mojodna]

Just toner and variants.

[sconnelley]

See
5c56f81
23d3a40

Retina support for "toner" is in there, will expand that to variants in a bit.

[sconnelley]

Everything seems to be working like expected, I would like to test a little more before pushing this out to the world. @mojodna - Is there a formal staging server for map.stamen.com?

[mojodna]

Not now, but there should be. If you have time and interest, maybe tackle #41?

[mojodna]

Probably drop the attribution and interactivity from these?

[sconnelley]

yep, will do

[mojodna]

Blue link text vs. black:

[mojodna]

err, in that case, white. i was thinking attribution links too.

[sconnelley]

Static mini maps should now be fixed.
Yeah some of the styles are a little messed up probably getting overriden by leaflet styles. Will fix them tonight

[sconnelley]

I can take on #41 as well.

[sconnelley]

closing this as it seems most issues have been resolved. We can kick up specific issues as necessary

[JLuc]

It seems the new leaflet version automaticaly request retina version when it thinks it's required... but there is no watercolor retina display version

So what about watercolor @2x version ?

No issue for toner-labels

[almccon]

@JLuc thanks for this feedback. We have no plans to produce a retina version of watercolor. Maybe there is some other workaround here?

[JLuc]

Ok i'll see.
Is watercolor the only one missing retina or do some other stamen layers not provide retina tiles ?