debounce: clear emit timer interval on stop #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not do this there is possible bug, when timer is set (not executed) and stream stopped if timer interval is not cleared it results in infinite emitting (not sure why emitting is looped). I don't have a clean simple repro example, but it happened in my app, had to debug it. Any way seems logical to clear not executed interval on stop, and not to clear is potential wrong.
|
@staltz this is a bug. |
|
@whitecolor Sorry it took ridiculously long to merge this. I'll publish version 11.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a possible bug when timer is set (not yet executed) and stream stopped. If timer interval is not cleared it results in infinite emitting (not sure why emitting is looped).
I don't have a clean simple repro example, but it happened in my app, had to debug it.
Anyway it seems logical to clear not executed emit interval on
stop, and not to clear it is a potential problem.