Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remember not working properly #27

Closed
ntilwalli opened this issue Apr 29, 2016 · 3 comments
Closed

remember not working properly #27

ntilwalli opened this issue Apr 29, 2016 · 3 comments
Labels
issue is bug weight 4 (must)

Comments

@ntilwalli
Copy link

Odd issue. When I call debug before calling remember it works properly but when I don't call debug the initial state is not seen by the second listener to a stream. http://www.webpackbin.com/4yza792lZ

Subsequent states (after the initial one) are seen properly, it's the initial state that is missed by the second subscriber
@staltz
Copy link
Owner

staltz commented Apr 29, 2016

@ntilwalli Thanks for reporting, we'll look into it

staltz added a commit that referenced this issue Apr 30, 2016
@staltz
fix(remember): build safety against map+map fusion
079602c 
If remember() was in between two map operators, the downstream map would attempt a map+map fusion
filter, bypassing remember, causing bugs. Now remember() is fixed so the downstream map will see a
producer meant for the remember, and hence wont optimize.

For issue #27.
@staltz
Copy link
Owner

staltz commented Apr 30, 2016

@ntilwalli version 2.1.1 released with a fix for this

@staltz staltz closed this as completed Apr 30, 2016
@ntilwalli
Copy link
Author

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue is bug weight 4 (must)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@staltz @ntilwalli