Stream throws instead of calling error listener when using .map

[lachenmayer]

Hi there, I'm not sure if this a bug or intended behaviour.

I have a stream of things, and I'm calling a validation function (eg. isValid) which may throw.

This is the expected behavior:

thing$
  .filter(isValid)
  .addListener({next: console.log, error: console.error})
// error is printed using error listener

However, when I try to add a map operator, the error does not get passed to the error listener, as expected. The exception is not handled at all.

thing$
  .filter(isValid)
+  .map(x => {type: 'success', payload: x})
  .addListener({next: console.log, error: console.error})
// throws!

I've tried using other operators like take or another filter, after the initial (throwing) filter, and those work as expected, ie. the error listener is called.

Here is an executable example, if this is unclear: https://runkit.com/lachenmayer/xstream-error-handling

version: 10.3.0

[staltz]

Oh it seems like we missed a try catch

xstream/src/index.ts

Line 1028 in 8f2503a

if (!this.passes(t)) return;

Certainly a bug and certainly fixable

[staltz]

This is now fixed in xstream v10.4