Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

replace pr#75 #77

Merged
merged 8 commits into from
Sep 6, 2020
Merged

replace pr#75 #77

merged 8 commits into from
Sep 6, 2020

Conversation

nglvnyls
Copy link
Contributor

this pr should replace pr#75.
Includes changes requested in the review

@netlify
Copy link

netlify bot commented Aug 30, 2020

Deploy preview for ca-reactjs ready!

Built with commit 487eb18

https://deploy-preview-77--ca-reactjs.netlify.app

@nglvnyls nglvnyls mentioned this pull request Aug 30, 2020
Closed
@netlify
Copy link

netlify bot commented Aug 30, 2020 •
edited
Loading

Deploy preview for ca-reactjs ready!

Built with commit 3b3178f

https://deploy-preview-77--ca-reactjs.netlify.app

seraco
seraco approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@seraco seraco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the contribution. 💪

In general it looks good to me. I just left a few more suggestions.

@nglvnyls nglvnyls mentioned this pull request Sep 2, 2020
Closed
88 tasks
@nglvnyls
Copy link
Contributor Author

nglvnyls commented Sep 3, 2020 •
edited
Loading

Thanks to you and @pepjo for manteining this site. I hope to make more contributions.

@seraco seraco merged commit cbf25a4 into stale-reactjs-org-translations:master Sep 6, 2020
@pepjo
Copy link
Contributor

pepjo commented Sep 11, 2020

Merged, thank you very much @nglvnyls !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seraco seraco seraco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nglvnyls @pepjo @seraco