Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Hello world #13

Merged
merged 7 commits into from
Jul 13, 2019
Merged

Hello world #13

merged 7 commits into from
Jul 13, 2019

Conversation

pepjo
Copy link
Contributor

@pepjo pepjo commented Jul 13, 2019 •
edited
Loading

Translation of basics, hello world to Catalan

@tesseralis tesseralis mentioned this pull request Jul 13, 2019
Closed
88 tasks
@pepjo pepjo changed the title WIP: Hello world Hello world Jul 13, 2019
@pepjo pepjo requested a review from seraco July 13, 2019 12:16
@pepjo pepjo assigned pepjo and seraco and unassigned seraco Jul 13, 2019
seraco
seraco approved these changes Jul 13, 2019
View reviewed changes
Copy link
Contributor

@seraco seraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation have been reviewed and it should be ready for merge now.

content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
@seraco seraco requested review from seraco and removed request for seraco July 13, 2019 15:02
seraco
seraco suggested changes Jul 13, 2019
View reviewed changes
Copy link
Contributor

@seraco seraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After modifying the proposed changes it should be ready for merge.

seraco
seraco suggested changes Jul 13, 2019
View reviewed changes
Copy link
Contributor

@seraco seraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the translation of "Try on CodePen" suggestions

pepjo and others added 2 commits July 13, 2019 16:36
@pepjo @seraco
Update content/docs/hello-world.md
375c79c 
Co-Authored-By: seraco <seraco@users.noreply.github.com>
@pepjo @seraco
Update content/docs/hello-world.md
94ea909 
Co-Authored-By: seraco <seraco@users.noreply.github.com>
@pepjo
Copy link
Contributor Author

pepjo commented Jul 13, 2019

Review and accepted the suggestions

@pepjo pepjo requested a review from seraco July 13, 2019 15:36
@seraco seraco merged commit 719fe61 into master Jul 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seraco seraco seraco approved these changes

Assignees

@pepjo pepjo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pepjo @seraco