Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit testing CI #111

Merged
merged 3 commits into from
Nov 3, 2019
Merged

Fix unit testing CI #111

merged 3 commits into from
Nov 3, 2019

Conversation

allejo
Copy link
Member

@allejo allejo commented Nov 3, 2019

Summary

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed issues N/A

Description

The unit testing CI jobs have been broken for long enough. AppVeyor broke because of a Chocolatey update. PHP 7.4 support has been merged in and fixed.

Check List

  • Added appropriate PhpDoc for modifications
  • Added unit test to ensure fix works as intended

@allejo allejo merged commit bae29c1 into develop Nov 3, 2019
@allejo allejo deleted the hotfix/7.4-testing branch November 3, 2019 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant