Manual release workflows #722

MuneebAijaz · 2024-08-02T07:28:56Z

This PR reflects the following set of changes:

Vulnerability in Golang 1.21
Fixing slack.stakater.com url
Switching to manual git releases instead of automated workflows
Merging PRs will create reloader:merge-<pr-number> tags
Disabling steps which write back to master branch (for now)
Step for pushing docs image will now run with push.yaml and release.yaml workflows, instead of separately, to avoid conflicts.
Tagging ghcr image as latest which will be used in plain manifests, removing a need to write back to main
Disabling the flow of pushing chart from this repo. Instead, chart will be moved to https://github.com/stakater/charts repo in the upcoming PRs.

rasheedamir · 2024-08-08T05:55:48Z

@MuneebAijaz why are we doing this?

Disabling the flow of pushing chart from this repo. Instead, chart will be moved to https://github.com/stakater/charts repo in the upcoming PRs.

MuneebAijaz · 2024-08-08T06:08:02Z

@MuneebAijaz why are we doing this?

pipeline write back to master branch as of now, because of two things, which fail on almost every run. updates in charts and plain manifests. Plain manifests part is being catered in this PR.
As for the charts, it should have separate release process from code. As it makes no sense to update a chart when only image tag is changed. Thats why it was decided to move it to stakater/charts and have divergent release workflows for both chart and code.

rasheedamir · 2024-08-08T06:14:08Z

Moving to separate repo shouldn't be required; we can have separate pipelines that runs on changes in different directories and then name the releases accordingly e.g. reloader-chart and reloader-image

MuneebAijaz · 2024-08-08T06:49:33Z

This PR just disables the current workflows. Any discussions about the charts should be moved here #684

.github/workflows/release.yaml

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [reloader](https://redirect.github.com/stakater/Reloader) | minor | `1.0.121` -> `1.1.0` | --- ### Release Notes <details> <summary>stakater/Reloader (reloader)</summary> ### [`v1.1.0`](https://redirect.github.com/stakater/Reloader/releases/tag/v1.1.0) [Compare Source](https://redirect.github.com/stakater/Reloader/compare/v1.0.121...v1.1.0) #### Announcement 📢 📢 📢 Discussions are being done internally on `how to release helm charts`, it is highly likely that the release **versioning of helm chart and images will become divergent** from next release onwards. (Different versioning for both artifacts, for example git release of `v1.1.1` might not have a chart released with the same version) Pls edit your automated workflows to accommodate for this change before the new release to have seamless updates in your clusters. #### What's Changed - Manual release workflows by [@MuneebAijaz](https://redirect.github.com/MuneebAijaz) in [https://github.com/stakater/Reloader/pull/722](https://redirect.github.com/stakater/Reloader/pull/722) - fixing go vet issues with logrus by [@bnallapeta](https://redirect.github.com/bnallapeta) in [https://github.com/stakater/Reloader/pull/727](https://redirect.github.com/stakater/Reloader/pull/727) - Fixing Rollout restart, Previously would trigger rollout deployment strategy by [@jangeja](https://redirect.github.com/jangeja) in [https://github.com/stakater/Reloader/pull/724](https://redirect.github.com/stakater/Reloader/pull/724) - Misc fixes to workflows by [@MuneebAijaz](https://redirect.github.com/MuneebAijaz) in [https://github.com/stakater/Reloader/pull/728](https://redirect.github.com/stakater/Reloader/pull/728) - docs: update wording in readme by [@deggja](https://redirect.github.com/deggja) in [https://github.com/stakater/Reloader/pull/730](https://redirect.github.com/stakater/Reloader/pull/730) - chore(deps): update dependency stakater/vale-package to v0.0.33 by [@renovate](https://redirect.github.com/renovate) in [https://github.com/stakater/Reloader/pull/721](https://redirect.github.com/stakater/Reloader/pull/721) - Reduce footprint of UBI images by [@bainsy88](https://redirect.github.com/bainsy88) in [https://github.com/stakater/Reloader/pull/717](https://redirect.github.com/stakater/Reloader/pull/717) - Update dependencies by [@MuneebAijaz](https://redirect.github.com/MuneebAijaz) in [https://github.com/stakater/Reloader/pull/735](https://redirect.github.com/stakater/Reloader/pull/735) #### New Contributors - [@jangeja](https://redirect.github.com/jangeja) made their first contribution in [https://github.com/stakater/Reloader/pull/724](https://redirect.github.com/stakater/Reloader/pull/724) - [@deggja](https://redirect.github.com/deggja) made their first contribution in [https://github.com/stakater/Reloader/pull/730](https://redirect.github.com/stakater/Reloader/pull/730) - [@bainsy88](https://redirect.github.com/bainsy88) made their first contribution in [https://github.com/stakater/Reloader/pull/717](https://redirect.github.com/stakater/Reloader/pull/717) **Full Changelog**: stakater/Reloader@v1.0.121...v1.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate).  Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [reloader](https://redirect.github.com/stakater/Reloader) | minor | `1.0.121` -> `1.1.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>stakater/Reloader (reloader)</summary> ### [`v1.1.0`](https://redirect.github.com/stakater/Reloader/releases/tag/v1.1.0) [Compare Source](https://redirect.github.com/stakater/Reloader/compare/v1.0.121...v1.1.0) #### Announcement 📢 📢 📢 Discussions are being done internally on `how to release helm charts`, it is highly likely that the release **versioning of helm chart and images will become divergent** from next release onwards. (Different versioning for both artifacts, for example git release of `v1.1.1` might not have a chart released with the same version) Pls edit your automated workflows to accommodate for this change before the new release to have seamless updates in your clusters. #### What's Changed - Manual release workflows by [@MuneebAijaz](https://redirect.github.com/MuneebAijaz) in [https://github.com/stakater/Reloader/pull/722](https://redirect.github.com/stakater/Reloader/pull/722) - fixing go vet issues with logrus by [@bnallapeta](https://redirect.github.com/bnallapeta) in [https://github.com/stakater/Reloader/pull/727](https://redirect.github.com/stakater/Reloader/pull/727) - Fixing Rollout restart, Previously would trigger rollout deployment strategy by [@jangeja](https://redirect.github.com/jangeja) in [https://github.com/stakater/Reloader/pull/724](https://redirect.github.com/stakater/Reloader/pull/724) - Misc fixes to workflows by [@MuneebAijaz](https://redirect.github.com/MuneebAijaz) in [https://github.com/stakater/Reloader/pull/728](https://redirect.github.com/stakater/Reloader/pull/728) - docs: update wording in readme by [@deggja](https://redirect.github.com/deggja) in [https://github.com/stakater/Reloader/pull/730](https://redirect.github.com/stakater/Reloader/pull/730) - chore(deps): update dependency stakater/vale-package to v0.0.33 by [@renovate](https://redirect.github.com/renovate) in [https://github.com/stakater/Reloader/pull/721](https://redirect.github.com/stakater/Reloader/pull/721) - Reduce footprint of UBI images by [@bainsy88](https://redirect.github.com/bainsy88) in [https://github.com/stakater/Reloader/pull/717](https://redirect.github.com/stakater/Reloader/pull/717) - Update dependencies by [@MuneebAijaz](https://redirect.github.com/MuneebAijaz) in [https://github.com/stakater/Reloader/pull/735](https://redirect.github.com/stakater/Reloader/pull/735) #### New Contributors - [@jangeja](https://redirect.github.com/jangeja) made their first contribution in [https://github.com/stakater/Reloader/pull/724](https://redirect.github.com/stakater/Reloader/pull/724) - [@deggja](https://redirect.github.com/deggja) made their first contribution in [https://github.com/stakater/Reloader/pull/730](https://redirect.github.com/stakater/Reloader/pull/730) - [@bainsy88](https://redirect.github.com/bainsy88) made their first contribution in [https://github.com/stakater/Reloader/pull/717](https://redirect.github.com/stakater/Reloader/pull/717) **Full Changelog**: stakater/Reloader@v1.0.121...v1.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate).

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [reloader](https://redirect.github.com/stakater/Reloader) | minor | `1.0.121` -> `1.1.0` | --- ### Release Notes <details> <summary>stakater/Reloader (reloader)</summary> ### [`v1.1.0`](https://redirect.github.com/stakater/Reloader/releases/tag/v1.1.0) [Compare Source](https://redirect.github.com/stakater/Reloader/compare/v1.0.121...v1.1.0) ##### Announcement 📢 📢 📢 Discussions are being done internally on `how to release helm charts`, it is highly likely that the release **versioning of helm chart and images will become divergent** from next release onwards. (Different versioning for both artifacts, for example git release of `v1.1.1` might not have a chart released with the same version) Pls edit your automated workflows to accommodate for this change before the new release to have seamless updates in your clusters. ##### What's Changed - Manual release workflows by [@MuneebAijaz](https://redirect.github.com/MuneebAijaz) in [https://github.com/stakater/Reloader/pull/722](https://redirect.github.com/stakater/Reloader/pull/722) - fixing go vet issues with logrus by [@bnallapeta](https://redirect.github.com/bnallapeta) in [https://github.com/stakater/Reloader/pull/727](https://redirect.github.com/stakater/Reloader/pull/727) - Fixing Rollout restart, Previously would trigger rollout deployment strategy by [@jangeja](https://redirect.github.com/jangeja) in [https://github.com/stakater/Reloader/pull/724](https://redirect.github.com/stakater/Reloader/pull/724) - Misc fixes to workflows by [@MuneebAijaz](https://redirect.github.com/MuneebAijaz) in [https://github.com/stakater/Reloader/pull/728](https://redirect.github.com/stakater/Reloader/pull/728) - docs: update wording in readme by [@deggja](https://redirect.github.com/deggja) in [https://github.com/stakater/Reloader/pull/730](https://redirect.github.com/stakater/Reloader/pull/730) - chore(deps): update dependency stakater/vale-package to v0.0.33 by [@renovate](https://redirect.github.com/renovate) in [https://github.com/stakater/Reloader/pull/721](https://redirect.github.com/stakater/Reloader/pull/721) - Reduce footprint of UBI images by [@bainsy88](https://redirect.github.com/bainsy88) in [https://github.com/stakater/Reloader/pull/717](https://redirect.github.com/stakater/Reloader/pull/717) - Update dependencies by [@MuneebAijaz](https://redirect.github.com/MuneebAijaz) in [https://github.com/stakater/Reloader/pull/735](https://redirect.github.com/stakater/Reloader/pull/735) ##### New Contributors - [@jangeja](https://redirect.github.com/jangeja) made their first contribution in [https://github.com/stakater/Reloader/pull/724](https://redirect.github.com/stakater/Reloader/pull/724) - [@deggja](https://redirect.github.com/deggja) made their first contribution in [https://github.com/stakater/Reloader/pull/730](https://redirect.github.com/stakater/Reloader/pull/730) - [@bainsy88](https://redirect.github.com/bainsy88) made their first contribution in [https://github.com/stakater/Reloader/pull/717](https://redirect.github.com/stakater/Reloader/pull/717) **Full Changelog**: stakater/Reloader@v1.0.121...v1.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/anza-labs/manifests).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Manual release workflows

7b61a74

MuneebAijaz marked this pull request as draft August 2, 2024 07:29

fix slack stakater url

3d14a84

This was linked to issues Aug 2, 2024

Consider changing release strategy #685

Closed

Unable to join Slack - asking question here instead :/ #711

Closed

MuneebAijaz added 5 commits August 2, 2024 14:24

pass version image to ubi base

3cca864

changes

2abd116

fixes

17b4979

fixes

474b925

fix dockerfile version

3c26665

MuneebAijaz linked an issue Aug 6, 2024 that may be closed by this pull request

[Security-Issue] CVE-2024-24790 in golang-1.21 #720

Closed

MuneebAijaz added 3 commits August 6, 2024 10:52

test docs workflow

93f8467

add docs workflow in manual release

181b88a

fix plain manifests

26f28e6

MuneebAijaz marked this pull request as ready for review August 6, 2024 09:54

resolve conflicts

7df32ae

bnallapeta previously approved these changes Aug 9, 2024

View reviewed changes

SheryarButt reviewed Aug 9, 2024

View reviewed changes

feedback

86f33de

MuneebAijaz dismissed bnallapeta’s stale review via 86f33de August 12, 2024 07:04

SheryarButt approved these changes Aug 13, 2024

View reviewed changes

MuneebAijaz merged commit 7d50d13 into master Aug 13, 2024
7 checks passed

MuneebAijaz deleted the manual-release branch August 13, 2024 11:18

karl-johan-grahn mentioned this pull request Oct 16, 2024

v1.1.0 tagged manifest image is on latest #753

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manual release workflows #722

Manual release workflows #722

MuneebAijaz commented Aug 2, 2024 •

edited

Loading

rasheedamir commented Aug 8, 2024

MuneebAijaz commented Aug 8, 2024

rasheedamir commented Aug 8, 2024

MuneebAijaz commented Aug 8, 2024

Manual release workflows #722

Manual release workflows #722

Conversation

MuneebAijaz commented Aug 2, 2024 • edited Loading

rasheedamir commented Aug 8, 2024

MuneebAijaz commented Aug 8, 2024

rasheedamir commented Aug 8, 2024

MuneebAijaz commented Aug 8, 2024

MuneebAijaz commented Aug 2, 2024 •

edited

Loading