Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): redundant container security contexts #458

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(helm): redundant container security contexts #458

merged 1 commit into from
Dec 11, 2024

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Nov 9, 2024 •
edited
Loading

Fixes #428

  • Remove forecastle.container.securityContext from values.yaml
  • Remove duplicate container security context mapping
  • Merge forecastle.container.securityContext and forecastle.deployment.securityContext to keep backward compatibility

@aslafy-z aslafy-z marked this pull request as ready for review November 9, 2024 16:59
@karl-johan-grahn
Copy link
Contributor

@aslafy-z would it be possible for you to add a unit test for this? The issue can be reproduced with helm template.

Unit test could be added with d3adb5/helm-unittest-action. Example tests: https://github.com/d3adb5/helm-unittest-action/blob/master/example-chart/tests/example_test.yaml

@aslafy-z
fix(helm): redundant container security contexts
e56b4fc 
Signed-off-by: GitHub <noreply@github.com>
@aslafy-z
Copy link
Contributor Author

aslafy-z commented Dec 4, 2024

@karl-johan-grahn I added tests to cover this securityContext thing

@karl-johan-grahn karl-johan-grahn merged commit aef4f73 into stakater:master Dec 11, 2024
2 checks passed
@aslafy-z aslafy-z deleted the patch-3 branch December 11, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karl-johan-grahn karl-johan-grahn karl-johan-grahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] the chart creates a duplicate security context under certain conditions
2 participants
@aslafy-z @karl-johan-grahn