Add Ingress TLS Hosts slice length check to avoid runtime panic #358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
pkg/kube/wrappers/ingress.go
thetryGetTLSHost
method accessesingress.Spec.TLS[0].Hosts[0]
without ensuring that theHosts
slice is non-empty. This causes a runtime panic if an Ingress object with emptyTLS
is encountered as given below:This PR introduces a new method on the
IngressWrapper
to fetch TLS HostsThe output of this method is used as a check in the
tryGetTLSHosts
method to ensure that out of index access panic does not occur.Closes #345
Test cases
A new test case has been introduced to simulate an Ingress with empty TLS.