Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minhtrung23:fix-pylint #36

Merged
merged 39 commits into from
Sep 10, 2024
Merged

Conversation

minhtrung23
Copy link

No description provided.

@minhtrung23 minhtrung23 closed this Sep 4, 2024
@minhtrung23 minhtrung23 reopened this Sep 4, 2024
@martinakaduc martinakaduc changed the title Minhtrung23fix pylint minhtrung23:fix-pylint Sep 4, 2024
@ledong0110
Copy link
Collaborator

ledong0110 commented Sep 5, 2024

@minhtrung23 cc @martinakaduc
In .github/workflow/python-package.yml

  • You should use pip install -e . instead of pip install -r requirements.txt
  • Package google-generativeai only supports python >= 3.9
  • The unit tests execute on LLMs which require a lot of memory space, so it's infeasible to run the test on workflow

@minhtrung23 minhtrung23 closed this Sep 7, 2024
@minhtrung23 minhtrung23 reopened this Sep 7, 2024
@sangttruong sangttruong marked this pull request as draft September 8, 2024 07:23
@minhtrung23 minhtrung23 marked this pull request as ready for review September 10, 2024 10:43
@martinakaduc martinakaduc changed the base branch from main to dev September 10, 2024 16:25
@martinakaduc martinakaduc merged commit a7d6332 into stair-lab:dev Sep 10, 2024
martinakaduc added a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants