Use default map layer if other URLs are not set #797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
If the URL of a map layer is empty or not specified, fall back to the default map layer.
Rationale
This way it is possible use stadtnavi with only one background map by setting only one map URL:
config.URL.MAP.default
.It is already possible to hide the map layer selector via
config.map.showLayerSelector
. But if one searches for connections and selects one with bike sections, themapMode
changes toMapMode.Bicycle
.Before this commit, this resulted in an error where one does no longer see any map. With the proposed changes, the background would not change and still work.
Pull Request Check List
Sorry that I did not add a test case so far. Do you think this is necessary? What kind of test would be ideal?
Review