Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default map layer if other URLs are not set #797

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

langbein-daniel
Copy link

Proposed Changes

If the URL of a map layer is empty or not specified, fall back to the default map layer.

Rationale

This way it is possible use stadtnavi with only one background map by setting only one map URL: config.URL.MAP.default.

It is already possible to hide the map layer selector via config.map.showLayerSelector. But if one searches for connections and selects one with bike sections, the mapMode changes to MapMode.Bicycle.

Before this commit, this resulted in an error where one does no longer see any map. With the proposed changes, the background would not change and still work.

Pull Request Check List

Sorry that I did not add a test case so far. Do you think this is necessary? What kind of test would be ideal?

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants