Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse exits from banner components #398

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Parse exits from banner components #398

merged 1 commit into from
Dec 17, 2024

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Dec 16, 2024

This is a follow up to #391, which parses out the exit numbers from the banner components. Note that this explicitly ignores all types other than "exit-number" for now.

@ahmedre
Parse exits from banner components
d4d8574 
This is a follow up to stadiamaps#391, which parses out the exit numbers from the
banner components. Note that this explicitly ignores all types other
than "exit-number" for now.
@ahmedre
Copy link
Contributor Author

ahmedre commented Dec 17, 2024

I had to manually update and force push to re-generate the ferrostar.swift file after the comment change. I couldn't figure out how to pull it with your suggestion merged so manually re-did it - git pull --rebase didn't get the changes

@ianthetechie
Copy link
Contributor

huh weird.... 🤷

@ianthetechie ianthetechie merged commit ea0a50e into stadiamaps:main Dec 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianthetechie ianthetechie ianthetechie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmedre @ianthetechie