Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proj centroid #38

Merged
merged 22 commits into from
May 3, 2023
Merged

add proj centroid #38

merged 22 commits into from
May 3, 2023

Conversation

philvarner
Copy link

Related Issue(s):

  • n/a

Proposed Changes:

  1. Add Projection Extension field proj:centroid

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

gadomski
gadomski previously approved these changes Apr 18, 2023
@philvarner
Copy link
Author

These tests pass locally, but fail in CI, so I'm going to have to figure out what the difference is.

@gadomski
Copy link
Contributor

These tests pass locally, but fail in CI, so I'm going to have to figure out what the difference is.

I'd look at shapely version first?

@philvarner
Copy link
Author

That was my thought too

@philvarner
Copy link
Author

I don't think is shapely -- for whatever reason, the calculation of the centroid returns an empty point, and I can't repro it locally, even after creating that same conda env 🤷🏻

@philvarner philvarner force-pushed the pv/add-proj-centroid branch from 51c4d2a to 592d521 Compare April 19, 2023 14:29
@gadomski
Copy link
Contributor

gadomski commented Apr 19, 2023

I don't think is shapely -- for whatever reason, the calculation of the centroid returns an empty point, and I can't repro it locally, even after creating that same conda env 🤷🏻

Next place I'd look is GEOS errors/warnings. I've seen times when libraries might not link up correctly, but it doesn't error on import; instead, it'll just break behavior in weird ways.

@philvarner philvarner requested a review from gadomski May 2, 2023 00:10
@gadomski gadomski removed the request for review from pholleway May 3, 2023 12:57
@philvarner philvarner enabled auto-merge (squash) May 3, 2023 13:45
@philvarner philvarner merged commit b0ad34f into main May 3, 2023
@philvarner philvarner deleted the pv/add-proj-centroid branch May 3, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants