Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] Publish a mac arm binary #404

Closed
charlesoconor opened this issue Sep 2, 2022 · 5 comments
Closed

[FEATURE_REQUEST] Publish a mac arm binary #404

charlesoconor opened this issue Sep 2, 2022 · 5 comments

Comments

@charlesoconor
Copy link
Contributor

It would be great to publish a prebuilt version of this tool for mac, darwin, arm. The old intel macs are harder to get you're hands on these days. My current workflow is using bazel to pull in the prebuilt and I have a custom-built artifact for people with arm macs.

I can try to add this functionality but it will be a little before I can get my hands on some hardware to test it.

@janisz
Copy link
Collaborator

janisz commented Sep 2, 2022

Hey, this makes sense. We need to:

  1. Add GOOS=darwin GOARCH=arm64 in makefile binary generation
    @CGO_ENABLED=0 GOOS=darwin scripts/go-build.sh ./cmd/kube-linter
  2. Handle arch in the build script (maybe we can handle it by concatenating $GOOS with $GOARCH 🤔 )
    output_file="bin/${GOOS}/${bin_name}"
  3. Handle new binary in release script
    update_release_draft:

@charlesoconor I can handle testing. I think I know somebody with Mac M1 who could run couple of commands for me 😄

@adam-thomas-privitar
Copy link

This is still a problem, not sure why the PR was closed. Frustrating as so many of us have arm macbooks in 2023.

@charlesoconor
Copy link
Contributor Author

I got side tracked since I've gotten all of the devs at my company to run rosetta for other reasons. The PR was closed since it wasn't ready meant to open it onto my own fork to check how the actions would work. Probably not to much more work is needed since go is very good a cross-compilation. I or someone needs to find the time.

@chulkilee
Copy link

For now I'm using brew to install kube-linter - but I'd like to install it from asdf plugin using the github release..

Seems like the release file name convention is changing as well (#380) so let's take it as an opportunity to add arch to the file name (or we may use amd64 as the old name)

(I don't know the status of "fat" go binary to support multiple arch)

@loeffel-io
Copy link

+1

charlesoconor added a commit to charlesoconor/kube-linter that referenced this issue Jan 23, 2024
charlesoconor added a commit to charlesoconor/kube-linter that referenced this issue Jan 24, 2024
charlesoconor added a commit to charlesoconor/kube-linter that referenced this issue Jan 24, 2024
charlesoconor added a commit to charlesoconor/kube-linter that referenced this issue Feb 15, 2024
@janisz janisz closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants