Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

growroot: Fix regex for md (sw-raid) cases #1279

Closed
wants to merge 1 commit into from
Closed

growroot: Fix regex for md (sw-raid) cases #1279

wants to merge 1 commit into from

Conversation

mnasiadka
Copy link
Member

No description provided.

@mnasiadka mnasiadka requested a review from a team as a code owner September 11, 2024 12:06
grzegorzkoper
grzegorzkoper approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@grzegorzkoper grzegorzkoper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1
Tested in SMSLAB

@markgoddard
Copy link

How does it relate to #818?

@mnasiadka
Copy link
Member Author

How does it relate to #818?

It doesn't, I haven't seen it - and given the endless thread in there and no resolution - maybe we can merge something that is not ideal but still helpful?

@markgoddard
Copy link

How does it relate to #818?

It doesn't, I haven't seen it - and given the endless thread in there and no resolution - maybe we can merge something that is not ideal but still helpful?

The issue is that there's scope for regression, and other related issues.

@mnasiadka
Copy link
Member Author

How does it relate to #818?

It doesn't, I haven't seen it - and given the endless thread in there and no resolution - maybe we can merge something that is not ideal but still helpful?

The issue is that there's scope for regression, and other related issues.

Let's go with #818, I tested it on all three possible disk names.

@mnasiadka mnasiadka closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzegorzkoper grzegorzkoper grzegorzkoper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnasiadka @markgoddard @grzegorzkoper