-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further fixes to Prometheus blackbox exporter endpoints #1254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be using the true jinja test rather than matching against the string, so I'd assume it would accept any truthy value. Evidently not
etc/kayobe/kolla/inventory/group_vars/prometheus-blackbox-exporter
Outdated
Show resolved
Hide resolved
c276cf5
to
52903dc
Compare
52903dc
to
1a3e80e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I helped write it so someone else should approve
1a3e80e
to
61e6336
Compare
horizon_public_port is dependent on backend_tls being enabled, rather than external tls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight scope creep but I'll allow it. LGTM but someone else should approve
I've kept the changes in separate commits, so at least it will be distinct in the blame. |
Enabled items under prometheus_blackbox_exporter_endpoints_kayobe were not picked up because the attribute gets set to
enabled: 'True'
, rather the thanenabled: true
that the default values get. Likely a similar issue to this:ansible/ansible#11905 (comment)