Allow to choose libraries as alternatives of ANGLE #116
Conversation
This change effectively enables to use Mesa instead of ANGLE.
|
This looks great to me. I don't have the expertise to review this properly though — @mikolalysenko would you have a look? |
|
Would this allow me to render without an X server? What's the status on this one? |
There was a problem hiding this comment.
Hi, @akihikodaki. Could you rebase on master? I've made some slight changes that cause conflicts in this PR, and may change the calls that you make to check for AngleInstancedArrays Support
| @@ -666,14 +666,6 @@ gl.getContextAttributes = function () { | |||
| return this._contextattributes | |||
| } | |||
|
|
|||
| gl.getSupportedExtensions = function getSupportedExtensions () { | |||
There was a problem hiding this comment.
Is the removal of getSupportedExtensions correct? Should it be kept in to only return the supported extensions (including a check for AngleInstanceArraysSupport)?
| @@ -874,6 +866,9 @@ function createANGLEInstancedArrays (context) { | |||
| return result | |||
| } | |||
|
|
|||
| var _checkAngleInstancedArraysSupport = gl.checkAngleInstancedArraysSupport | |||
There was a problem hiding this comment.
Does this need to be implemented in native code? Could the original gl.getSupportedExtensions (see latest code in master) be queried to return support for angleinstancedarrays?
For example, instead of calling _checkAngleInstancedArraysSupport, perhaps _getSupportedExtensions could be called, and the presence of "GL_ANGLE_instanced_arrays" could be checked.
This would simplify the changes in webgl.cc
|
I've updated this PR with latest master: https://github.com/stackgl/headless-gl/compare/master...descriptinc:aki-gl?expand=1&w=1 compiles on m1 mac with node 16.5.0 (that’s just what I had installed), and all tests pass |
|
@marcello3d Thanks – I'll review this in a few days. It might take a while as I'm not super familiar with mesa and other backends + not sure how to best allow customization when installing (whether it's prebuilt or not) + will need to configure testing for both backends. |
|
@marcello3d , Thanks for this PR! We you able to run it with EGL provided by https://hub.docker.com/r/nvidia/opengl ? |
|
@dhritzkiv , can we merge this PR? |
|
@stepancar Did you succeed to use EGL with that branch? |
|
@nicolasgere , not with this one, because I didn't figure out how to configure it. But I think this branch should work also. What I did is here (I followed recommendation from this comment #213 (comment)) I used https://hub.docker.com/r/nvidia/opengl as a base image like suggested here EGL works well for us |
|
@stepancar Sorry for the last reponse, why do you need an X server? can we do without it? |
|
I'm closing this. Instead you may have a look at: #116 (comment) |
|
I don't understand why this pull request was closed and not merged? |
This change effectively enables to use Mesa instead of ANGLE.
EDIT: This closes #102.