-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stg squash fails #157
Comments
Thank you for this issue report, @rgrinberg. I am able to reproduce the issue and am working on a repair. In the meantime, a workaround is to specify a name for the squashed patch on the command line with stg squash -n squashed $(stg top) other-patch |
jpgrayson
added a commit
that referenced
this issue
Oct 8, 2021
Attempting to squash two patches out of order without also specifying a name on the command line would cause new_commit_data to be None which would then trigger an exception when trying to derive the new patch name from the non-existent commit data. The issue is resolved by making _squash_patches() responsible for determining the new squashed patch name since it possesses the necessary commit data at the appropriate moment. Repairs #157. Signed-off-by: Peter Grayson <pete@jpgrayson.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following triggered the crash:
Let me know if you need more information.
Version information:
The text was updated successfully, but these errors were encountered: